Removed access to internal files

Summary: Removed any reference to FB internal files from the main sdk Reviewed By: kalendae Differential Revision: D9818575 fbshipit-source-id: 4625399eedf6b877b90c4c9b0d368b76bebcab4b
facebook · Sep 14, 2018 · 9b28f05 · 9b28f05
1 parent 166ac44
commit 9b28f05
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 51 deletions.
diff --git a/.gitignore b/.gitignore
@@ -27,8 +27,6 @@ ads/src/FB-SDK-MP/FB_SDK_MP_Workspace.xcworkspace/*
 ads/src/FB-SDK-MP/FB-SDK-MP.xcworkspace/*
 ads/src/FB-SDK-MP/FB-SDK-MP.xcodeproj/*
 
-internal/testing/IpaSizeTestApp/**/*.xcworkspace/*
-internal/testing/IpaSizeTestApp/**/*.xcodeproj/*
 samples/Hackbook/build/
 samples/Hackbook/Hackbook.xcodeproj/*.pbxuser
 samples/Hackbook/Hackbook.xcodeproj/*.mode*

diff --git a/FacebookSDK.xcworkspace/xcshareddata/xcschemes/BuildAllKits.xcscheme b/FacebookSDK.xcworkspace/xcshareddata/xcschemes/BuildAllKits.xcscheme
@@ -118,34 +118,6 @@
                ReferencedContainer = "container:FBSDKPlacesKit/FBSDKPlacesKit.xcodeproj">
             </BuildableReference>
          </BuildActionEntry>
-         <BuildActionEntry
-            buildForTesting = "NO"
-            buildForRunning = "YES"
-            buildForProfiling = "YES"
-            buildForArchiving = "YES"
-            buildForAnalyzing = "YES">
-            <BuildableReference
-               BuildableIdentifier = "primary"
-               BlueprintIdentifier = "D5C618081DC90E9000C406B9"
-               BuildableName = "FBSDKShareTray-Universal"
-               BlueprintName = "FBSDKShareTray-Universal"
-               ReferencedContainer = "container:internal/FBSDKShareTray/FBSDKShareTray.xcodeproj">
-            </BuildableReference>
-         </BuildActionEntry>
-         <BuildActionEntry
-            buildForTesting = "YES"
-            buildForRunning = "NO"
-            buildForProfiling = "NO"
-            buildForArchiving = "NO"
-            buildForAnalyzing = "YES">
-            <BuildableReference
-               BuildableIdentifier = "primary"
-               BlueprintIdentifier = "D5EAC5361DCA740D00F0ADC6"
-               BuildableName = "FBSDKShareTrayTests.xctest"
-               BlueprintName = "FBSDKShareTrayTests"
-               ReferencedContainer = "container:internal/FBSDKShareTray/FBSDKShareTray.xcodeproj">
-            </BuildableReference>
-         </BuildActionEntry>
       </BuildActionEntries>
    </BuildAction>
    <TestAction
@@ -184,16 +156,6 @@
                ReferencedContainer = "container:FBSDKShareKit/FBSDKShareKit.xcodeproj">
             </BuildableReference>
          </TestableReference>
-         <TestableReference
-            skipped = "NO">
-            <BuildableReference
-               BuildableIdentifier = "primary"
-               BlueprintIdentifier = "D5EAC5361DCA740D00F0ADC6"
-               BuildableName = "FBSDKShareTrayTests.xctest"
-               BlueprintName = "FBSDKShareTrayTests"
-               ReferencedContainer = "container:internal/FBSDKShareTray/FBSDKShareTray.xcodeproj">
-            </BuildableReference>
-         </TestableReference>
       </Testables>
       <MacroExpansion>
          <BuildableReference

diff --git a/scripts/build_distribution.sh b/scripts/build_distribution.sh
@@ -341,13 +341,6 @@ else
 		\cp -R "$FB_SDK_BUILD"/FBSDKMessengerShareKit.framework "$FB_SDK_BUILD_PACKAGE" \
 		  || die "Could not copy FBSDKMessengerShareKit.framework"
 
-		# Build Marketing Kit
-		if [ -z $SKIPBUILD ]; then
-			(xcodebuild -project "${FB_SDK_ROOT}"/internal/FBSDKMarketingKit/FBSDKMarketingKit.xcodeproj -scheme "FBSDKMarketingKit-universal" -configuration Release clean build) || die "Failed to build marketing kit"
-		fi
-		\cp -R "$FB_SDK_BUILD"/FBSDKMarketingKit.framework "$FB_SDK_BUILD_PACKAGE" \
-			|| die "Could not copy FBSDKMarketingKit.framework"
-
 		# Build docs
 		if [ -z $SKIPBUILD ]; then
 		  . "$FB_SDK_SCRIPT/build_documentation.sh"

diff --git a/scripts/build_framework.sh b/scripts/build_framework.sh
@@ -92,7 +92,7 @@ fi
 progress_message "Generating strings"
 (
   cd "$FB_SDK_ROOT"
-  find FBSDKCoreKit/ FBSDKShareKit/ FBSDKLoginKit/ FBSDKTVOSKit/ internal/FBSDKMarketingKit/ -name "*.m" | xargs genstrings -o FacebookSDKStrings.bundle/Resources/en.lproj/
+  find FBSDKCoreKit/ FBSDKShareKit/ FBSDKLoginKit/ FBSDKTVOSKit/ -name "*.m" | xargs genstrings -o FacebookSDKStrings.bundle/Resources/en.lproj/
 )
 
 # -----------------------------------------------------------------------------

diff --git a/scripts/run_tests.sh b/scripts/run_tests.sh
@@ -102,9 +102,6 @@ for SCHEME in $SCHEMES; do
     if [[ -n $FAILED_SAMPLES ]]; then
         die "Failed to build $FAILED_SAMPLES"
     fi
-    if [[ -a "internal/scripts/run_internal_tests.sh" ]]; then
-      source "internal/scripts/run_internal_tests.sh"
-    fi
   else
     COMMAND="xcodebuild
       -workspace FacebookSDK.xcworkspace \