Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support batch requests #77

Closed
bjeavons opened this issue Mar 15, 2015 · 12 comments
Closed

Support batch requests #77

bjeavons opened this issue Mar 15, 2015 · 12 comments

Comments

@bjeavons
Copy link
Contributor

Any plans to support batched requests using the Facebook Ads SDK?

@greggles
Copy link

I would also like this.

@monitotxi
Copy link

+1

@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@foxpcteam
Copy link

any news?

@bjeavons
Copy link
Contributor Author

I didn't see it before but v2.5 of the SDK supposedly supports batch requests: https://developers.facebook.com/docs/php/howto/example_batch_request

@allentsai
Copy link

Just running into this with our integration, would be nice to have. For now, we might be writing our own curl wrapper...

https://developers.facebook.com/docs/marketing-api/batch-requests/v2.5

@Mattin
Copy link
Contributor

Mattin commented May 23, 2016

I think batch requests are already in, I'm using it from v2.4 (for ads and insights download/import). For what exactly you want them?

@neok
Copy link

neok commented Aug 18, 2016

@Mattin for creating AdSets, Ads, AdCreatives

@ryancwalsh
Copy link

Is it true that facebook-php-ads-sdk doesn't support batch requests? (That's what http://stackoverflow.com/a/32530905/470749 says.)

Then why does the Ad object have a $pending param in public function getInsights(array $fields = array(), array $params = array(), $pending = false)? What does that allow?

I really just want to be able to grab insights for all active ads (across all campaigns within an account). The Insights edge doesn't seem to allow filtering by ads status, so I thought my approach would be to run 1 query to grab the IDs of all active ads and then run a batch of Insights queries (get the insights for each ad).

What would you recommend?

@ryancwalsh
Copy link

@paulbain Can you or someone please point us in the right direction? This has been open since Mar 2015. I think batch requests in the PHP Ads SDK would be great. Thanks!

@jingping2015
Copy link
Contributor

Hi, it seems like this issue has been open for more than a few months now. We have made many changes in the SDK since then, including releasing a new version. If you can repro your specific issue with the latest version of the SDK, please create a new issue or comment here with further details.

@greggles
Copy link

Not sure if this was a bulk close or if your comment was specific to this issue. I did a quick search and the page on async requests linked in the opening comment now has examples of using AdAsyncRequestSet, so it seems this is indeed fixed.

Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants