Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Faraday dependency to 2.x #184

Closed
multiplegeorges opened this issue Sep 21, 2022 · 2 comments
Closed

Update Faraday dependency to 2.x #184

multiplegeorges opened this issue Sep 21, 2022 · 2 comments

Comments

@multiplegeorges
Copy link

Which SDK version are you using?

0.14.0.0

What's the issue?

The Faraday connection created here does not specify a timeout or a way to configure a timeout on the request.

The gemspec requires an old version of Faraday.
With version 1.x of Faraday, we can't pass options to the adapters.
With version 2+ of Faraday, we can pass options to the adapters using Faraday.default_adapter_options. This would allow users to specify their own timeout configuration.

Steps/Sample code to reproduce the issue

require "http"
require "faraday"

Faraday.default_adapter = :http
Faraday.default_adapter_options = {timeout: 11}

Observed Results:

.../faraday-1.10.2/lib/faraday.rb:182:in `method_missing': undefined method `default_adapter_options=' for Faraday:Module (NoMethodError)

Expected Results:

If this gem would upgrade the Faraday gem, this would work.

@Zajn
Copy link

Zajn commented Nov 11, 2022

I opened #186 to hopefully get this bump to Faraday merged!

@olleolleolle
Copy link

Right, and this was addressed in 07f7689

@alanho alanho closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants