Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread Safety #30

Open
coreyward opened this issue Sep 26, 2017 · 13 comments
Open

Thread Safety #30

coreyward opened this issue Sep 26, 2017 · 13 comments

Comments

@coreyward
Copy link

The README has the following disclaimer:

We developed this SDK using Ruby 2.0, and supports Ruby 2.0+, however, the SDK is not thread-safe at the moment.

Is there a particular area of the SDK that isn't thread-safe that can be avoided? I see the with_session method definitely isn't; can we avoid some elements to utilize the library in threaded background workers now?

If not, what can be done to improve thread safety? Is it a matter of prioritization? Allocation of resources? Lack of interest?

Thanks!
@himberjack
Copy link

What's up with that? why in 2020 thread safe can't be done?

@stale
Copy link

stale bot commented Jan 22, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Jan 22, 2020
@himberjack
Copy link

Its not fixed

@stale stale bot removed the Stale label Jan 22, 2020
@stale
Copy link

stale bot commented Apr 21, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Apr 21, 2020
@coreyward
Copy link
Author

Not stale, just being ignored by the Facebook team.

@stale stale bot removed the Stale label Apr 21, 2020
@himberjack
Copy link

Not stale.

@stale
Copy link

stale bot commented Jul 20, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Jul 20, 2020
@coreyward
Copy link
Author

Still not stale.

@stale stale bot removed the Stale label Jul 21, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Dec 25, 2020
@ajjahn
Copy link

ajjahn commented Dec 29, 2020

Stale bot, please trade yourself in for Ignored bot. This issue is still not stale.

@stale stale bot removed the Stale label Dec 29, 2020
@stale
Copy link

stale bot commented Jan 8, 2022

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Jan 8, 2022
@stale stale bot removed the Stale label Feb 28, 2022
@himberjack
Copy link

What's up with that? why in 2020 thread safe can't be done?

why in 2022 thread safe can't be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@coreyward @ajjahn @himberjack and others