Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad leads causes infinite loop #61

Closed
arr-dev opened this issue Dec 27, 2018 · 3 comments
Closed

Ad leads causes infinite loop #61

arr-dev opened this issue Dec 27, 2018 · 3 comments
Labels

Comments

@arr-dev
Copy link

arr-dev commented Dec 27, 2018

Calling FacebookAds::Ad.get(ad_id).leads.all when there are more than limit results causes infinite loop,
since response doesn't include pagination data.

Only solution seems to be to place large enough limit, but that is not very safe,
since API itself can limit the maximum number of results returned, which can again cause same infinite loop.

Using latest versions of gem and API, 0.3.2.5 and 3.2.

@maxencehenneron
Copy link

same issue with minimum_budgets

FacebookAds::AdAccount.get(ad_account_id, 'name').minimum_budgets.all

@stale
Copy link

stale bot commented Jan 14, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Jan 14, 2020
@stale
Copy link

stale bot commented Jan 21, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants