Batch api does not return responses

[osdakira]

Which SDK version are you using?

[7] pry(main)> FacebookAds::VERSION
=> "0.3.2.9"
[11] pry(main)> RUBY_VERSION
=> "2.5.0"

What's the issue?

Batch API has the logic to return the response.
However, there is no return value because each_slice has been added.

facebook-ruby-business-sdk/lib/facebook_ads/batch_api/batch.rb

Lines 33 to 51 in bd80d59

	def execute
	return [] if operations.empty?
	operations.each_slice(50) do |slice|
	api_response = APIRequest.new(:post, '', session: session, params: batch_args(slice)).execute_now
	self.last_api_response = api_response
	slice.zip(api_response.result).map do |req, res|
	next unless res
	begin
	req.create_response(
	res['code'],
	convert_headers_to_hash(res['headers']),
	res['body'])
	rescue APIError => e
	e
	end
	end
	end
	end

Steps/Sample code to reproduce the issue

[4] pry(main)> require "facebookbusiness"
=> true
[5] pry(main)> session = FacebookAds::Session.new(access_token: access_token, app_secret: app_secret)
[6] pry(main)> batch = FacebookAds::Batch.with_batch do
  FacebookAds::AdAccount.get("act_#{ad_account_id}", session).name
[6] pry(main)* end 
[7] pry(main)> batch.execute
=> nil

Observed Results:

Enumerable#each_slice return nil.

https://ruby-doc.org/core-2.5.0/Enumerable.html#method-i-each_slice

Expected Results:

I added the map method.
It will be the expected result.

File: vendor/bundle/ruby/2.5.0/gems/facebookbusiness-0.3.2.9/lib/facebook_ads/batch_api/batch.rb
- 35:       operations.each_slice(50) do |slice|
+ 35:       operations.each_slice(50).map do |slice|

[6] pry(main)> batch.execute
=> [[#<FacebookAds::AdAccount {:id=>"act_****", :account_id=>"****"}>]]

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

[stale]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

[kurko]

I have this same issue.

[raszi]

This is still an issue, more than three years later! 😞