New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reletavise requires in compiled .flow files #118
Comments
mine |
👍 we might need to upgrade Babel for this to work, at least the plan I had On Friday, February 26, 2016, Sam Goldman <notifications@github.com
|
Thanks—pretty eager to get this fix out. Does a Babel upgrade have any blockers to landing, other than just getting it to work locally? |
I think the only thing I'd check is diff the JS files before and after to make sure we don't slip anything in there we don't expect. We have all the plugins ported already. And actually we're just about to do the upgrade for React in facebook/react#6113 |
Do we have anything else that uses Babel 5? I want to kill it with fire. |
@kittens If you're on a tear and want to take this one, go for it. I think you'll be able to turn it around faster than me. :) |
Literally everything else besides React Native still uses 5. |
Like what? React Native, Relay, www, and now React all use Babel 6. |
Relay doesn't use Babel 6, nor does flux nor draft. Nothing using On Friday, February 26, 2016, Sebastian McKenzie notifications@github.com
|
Thanks for the list, I'll upgrade all of those next week.. On Saturday, 27 February 2016, Paul O’Shannessy notifications@github.com
Sebastian McKenzie |
There's an issue right now where the result is that we basically force all indirect consumers of fbjs (eg using Relay) to use the haste system in their package or ignore things specifically. @mroch said we should be able to make this work with our projects and others by rewriting the requires in our generated flow files so they are relative while keeping the
@providesModule
headers.The text was updated successfully, but these errors were encountered: