Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow file rewriting results in invalid type annotation #123

Open
zpao opened this issue Mar 4, 2016 · 2 comments
Open

flow file rewriting results in invalid type annotation #123

zpao opened this issue Mar 4, 2016 · 2 comments

Comments

@zpao
Copy link
Member

zpao commented Mar 4, 2016

In compactArray we have

function compactArray<T>(
  array: Array<?T>
): Array<T> {

But it's getting rewritten by babel to

function compactArray<T>(array: Array<?TT>): Array<T> {

This is likely a bug in babel's printer but it's impacting us so we should try to own this. @samwgoldman - interested? (also cc @kittens because maybe it would take you 2 seconds). & cc @steveluscher since it's hitting Relay right now.

@zpao
Copy link
Member Author

zpao commented Mar 4, 2016

Oh, @samwgoldman called this out explicitly in 7baf1ff and I missed that and reverted the annotation. I'll just put it back to what it was changed to and add this to my mental list of things to revert manually next sync (until the babel bug is fixed)

@samwgoldman
Copy link
Member

;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants