New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no limitation for "%s" while calling fscanf() #90

Open

QiAnXinCodeSafe opened this issue Aug 26, 2020 · 2 comments

QiAnXinCodeSafe commented Aug 26, 2020

fboss/fboss/util/nic_util.cpp

Line 494 in 8865126

fscanf(fp, "%s", &sysfsPath[nChars]);

iris577 commented Mar 1, 2021

slogan621 commented Apr 1, 2021

Not only that, but sprintf on the line before would be more secure as snprintf, and strcat on the line after would be more secure as strncat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment