Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build error fmt format #549

Closed
restlesswind opened this issue Apr 10, 2023 · 2 comments
Closed

build error fmt format #549

restlesswind opened this issue Apr 10, 2023 · 2 comments

Comments

@restlesswind
Copy link

https://github.com/facebook/fbthrift/blob/main/thrift/lib/cpp2/server/ParallelConcurrencyController.cpp#L159

It seems like the line should look
"{{ParallelConcurrencyController executionLimit={}}}", executionLimit_.load());
instead of
"{{ParallelConcurrencyController executionLimit={}}}", executionLimit_);

@Mizuchi
Copy link
Contributor

Mizuchi commented Apr 18, 2023

Thanks for reporting. fmtlib broke it (fmtlib/fmt@fce74ca). Let me check with the author.

@vitaut
Copy link
Contributor

vitaut commented Apr 21, 2023

Fixed in ae49988.

@vitaut vitaut closed this as completed Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants