Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error: isMainProcess(Context) has private access in SonarUtils #14

Closed
andreiverdes opened this issue Jun 11, 2018 · 2 comments
Closed

error: isMainProcess(Context) has private access in SonarUtils #14

andreiverdes opened this issue Jun 11, 2018 · 2 comments

Comments

@andreiverdes
Copy link
Contributor

Pretty explanatory from the title :D
Trying to setup Sonar and I'm having a compile issue
andreiverdes added a commit to andreiverdes/Sonar that referenced this issue Jun 11, 2018
@andreiverdes
Fix facebookGH-14 isMainProcess(Context) has private access
972353c
@andreiverdes andreiverdes mentioned this issue Jun 11, 2018
Closed
@rohfosho
Copy link

You can use SonarUtils.shouldEnableClient(this) instead.

This checks if it's the main process, an end to end test, and if it's an internal build.

@andreiverdes
Copy link
Contributor Author

Oh okay, then :) the getting started guide was using that, closing this issue

@andreiverdes andreiverdes mentioned this issue Jun 11, 2018
Closed
andreiverdes added a commit to andreiverdes/Sonar that referenced this issue Jun 11, 2018
@andreiverdes
Fix facebookGH-22 wrong method for Android docs
d1e8a1f 
As per facebookGH-14 comment, the docs were pointing to an internal `private` method to check if `Sonar` should be enabled
@andreiverdes andreiverdes mentioned this issue Jun 11, 2018
Closed
facebook-github-bot pushed a commit that referenced this issue Jun 12, 2018
@andreiverdes @facebook-github-bot
Fix GH-22 wrong method for Android docs (#23)
1edffab 
Summary:
As per GH-14 comment, the docs were pointing to an internal `private` method to check if `Sonar` should be enabled
Closes #23

Reviewed By: danielbuechele

Differential Revision: D8379336

Pulled By: jknoxville

fbshipit-source-id: bc580dc40a1994a2f4a30544d77f86b60e9353f6
@hello-soon hello-soon mentioned this issue Nov 30, 2021
Closed
@xiaomaowu xiaomaowu mentioned this issue Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreiverdes @rohfosho