Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Getting Started docs Android #22

Closed
andreiverdes opened this issue Jun 11, 2018 · 0 comments
Closed

Fix Getting Started docs Android #22

andreiverdes opened this issue Jun 11, 2018 · 0 comments

Comments

@andreiverdes
Copy link
Contributor

Getting Started Android docs is using an internal private method to check if Sonar should be used.
As per GH-14 comment, it should point to SonarUtils.shouldEnableClient(this)
andreiverdes added a commit to andreiverdes/Sonar that referenced this issue Jun 11, 2018
@andreiverdes
Fix facebookGH-22 wrong method for Android docs
d1e8a1f 
As per facebookGH-14 comment, the docs were pointing to an internal `private` method to check if `Sonar` should be enabled
@amenon amenon mentioned this issue Jul 8, 2018
Closed
facebook-github-bot pushed a commit that referenced this issue Jul 10, 2018
@amenon @facebook-github-bot
Added docs for OkHttp integration (#144)
dad05de 
Summary:
This PR includes documentation for using the `SonarOkhttpInterceptor` for applications using the `OkHttp` network stack. The docs were modelled on the [Stetho docs](http://facebook.github.io/stetho/#enable-network-inspection)

Fixes #22.
Pull Request resolved: #144

Differential Revision: D8780506

Pulled By: danielbuechele

fbshipit-source-id: fb2ddd4356b421c3baf0a80a410dd579ebc1bd8d
@hello-soon hello-soon mentioned this issue Nov 30, 2021
Closed
@xiaomaowu xiaomaowu mentioned this issue Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andreiverdes