Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlipperOkhttpInterceptor making SSE not working #2495

Open
tmirun opened this issue Jun 21, 2021 · 11 comments
Open

FlipperOkhttpInterceptor making SSE not working #2495

tmirun opened this issue Jun 21, 2021 · 11 comments
Labels
help wanted Extra attention is needed plugin-network PR welcome We're looking for community members to implement this!

Comments

@tmirun
Copy link

tmirun commented Jun 21, 2021

馃悰 Bug Report

in the reactNativeFlipper.java, the following lines making EventSource (SSE) not working.

....
NetworkFlipperPlugin networkFlipperPlugin = new NetworkFlipperPlugin();
      NetworkingModule.setCustomClientBuilder(
          new NetworkingModule.CustomClientBuilder() {
            @Override
            public void apply(OkHttpClient.Builder builder) {
              builder.addNetworkInterceptor(new FlipperOkhttpInterceptor(networkFlipperPlugin));
            }
          });

Environment

Android, Flipper 0.93, react native 0.64.0

@tmirun
Copy link
Author

tmirun commented Jun 21, 2021

I am not sure if this is a bug or is normal behavior.

we discovered it in the following conversation:
facebook/react-native#28835

@axwell
Copy link

axwell commented Sep 10, 2021

any news about this ?

@tmirun
Copy link
Author

tmirun commented Sep 10, 2021

@axwell in production mode SSE/EventSource it is working, that networkFlipperPlugin is only applied in development mode, for you can intercept the network calls and show it in Flipper.

@mweststrate mweststrate added plugin-network help wanted Extra attention is needed labels Sep 14, 2021
@mweststrate
Copy link
Contributor

We don't really use the OkHttpClient interceptor internally, so if anybody wants to investigate if this could be wired better, PRs are welcome!

@mweststrate mweststrate added the PR welcome We're looking for community members to implement this! label Sep 14, 2021
@stale
Copy link

stale bot commented Jan 8, 2022

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale label Jan 8, 2022
@KillianH
Copy link

I'll like to keep this issue open :) We still have the same problem on our side too.

@stale stale bot removed the Stale label Jan 11, 2022
@mweststrate
Copy link
Contributor

You're interested in investigating it further? Otherwise there is little value in keeping issues open that no one is willing to invest in.

@forkball
Copy link

forkball commented Feb 15, 2023

Yeah, ran into this issue at work today. Works fine on release versions of Android apps, but not debug.

What does this specific snippet of code do? Is it required to use Flipper in normal debugging practices?

@forkball
Copy link

Still looking for some insight into this code snippet.

What does this specific snippet of code do? Is it required to use Flipper in normal debugging practices?

@fa2id
Copy link

fa2id commented May 10, 2023

Same here. @forkball Did you find any solution?

@forkball
Copy link

Same here. @forkball Did you find any solution?

I just commented the snippet in question out for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed plugin-network PR welcome We're looking for community members to implement this!
Projects
None yet
Development

No branches or pull requests

6 participants