Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS physical device support #76

Closed
qokelate opened this issue Jun 15, 2018 · 4 comments
Closed

Add iOS physical device support #76

qokelate opened this issue Jun 15, 2018 · 4 comments
Labels

Comments

@qokelate
Copy link

Sonar.app iOS not found, any help?

my code:

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
   ......
       SonarClient *client = [SonarClient sharedClient];
    SKDescriptorMapper *mapper = [[SKDescriptorMapper alloc] initWithDefaults];
    [client addPlugin:[[SonarKitLayoutPlugin alloc] initWithRootNode:application withDescriptorMapper:mapper]];
    [client start];
   ......
}

@ranchen516
Copy link

+1

@danielbuechele
Copy link
Contributor

Can you try executing this command in your terminal an see if that works:

xcrun simctl list devices json

@qokelate
Copy link
Author

qokelate commented Jun 15, 2018

It works on simulator! How to setup in actual device?

@jknoxville
Copy link
Contributor

At the moment, for iOS, sonar only supports physical devices.
There's a note on this page but we should probably make it more prominent: https://fbsonar.com/docs/getting-started.html

The reason is that on android, we can use adb to write sonar's CA certificate to the app's internal data directory over usb. This certificate then gets pinned in the app so it can trust sonar.
But on iOS, there is no such mechanism to do this, so we'll have to devise an alternate method of securely deploying the desktop's sonar certificate to the mobile app, and/or introduce an optional opt-out config setting for desktop-app verification.

@jknoxville jknoxville changed the title No devices running -- iOS Add iOS physical device support Jun 21, 2018
@jknoxville jknoxville added the iOS label Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants