Fix fbstring hash

Summary: '\0' may actually be part of string. We cannot assume its null terminated and should use another form of fnv32. Test Plan: FBStringTest Reviewed By: xliux@fb.com FB internal diff: D595287
facebook · Oct 12, 2012 · 0578370 · 0578370
1 parent 1fd9e62
commit 0578370
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/folly/FBString.h b/folly/FBString.h
@@ -2304,7 +2304,7 @@ namespace std {
 template <>
 struct hash< ::folly::fbstring> {
   size_t operator()(const ::folly::fbstring& s) const {
-    return ::folly::hash::fnv32(s.c_str());
+    return ::folly::hash::fnv32_buf(s.data(), s.size());
   }
 };
 }

diff --git a/folly/test/FBStringTest.cpp b/folly/test/FBStringTest.cpp
@@ -995,6 +995,18 @@ TEST(FBString, testFixedBugs) {
   }
 }
 
+
+TEST(FBString, testHash) {
+  fbstring a;
+  fbstring b;
+  a.push_back(0);
+  a.push_back(1);
+  b.push_back(0);
+  b.push_back(2);
+  std::hash<fbstring> hashfunc;
+  EXPECT_NE(hashfunc(a), hashfunc(b));
+}
+
 int main(int argc, char** argv) {
   testing::InitGoogleTest(&argc, argv);
   google::ParseCommandLineFlags(&argc, &argv, true);