Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

folly errors when wdt is being built with cygwin64 on windows #1358

Open
foroughmajidi opened this issue Apr 27, 2020 · 3 comments
Open

folly errors when wdt is being built with cygwin64 on windows #1358

foroughmajidi opened this issue Apr 27, 2020 · 3 comments

Comments

@foroughmajidi
Copy link

foroughmajidi commented Apr 27, 2020

I generated makefiles of wdt as following:
cmake -DGFLAGS_INCLUDE_DIR=G:/cygwin64/usr/local/include/gflags
-DGLOG_INCLUDE_DIR=G:/cygwin64/usr/local/include/glog
-DDOUBLECONV_INCLUDE_DIR=G:/cygwin64/usr/local/include/double-conversion
-DFOLLY_SOURCE_DIR=G:/cygwin64/home/Forough/w_f

The generating concluded to this result:

Capture29

When I run :make -j I got this result:

Capture30

Although I added these code to folly/system/ThreadId.h , I receive the mentioned error.
#if __linux
#include <folly/portability/SysSyscall.h>*/
#elif defined(_WIN32) || defined(_WIN64)
#include <folly/portability/windows.h>

Please help me with the problem

@foroughmajidi
Copy link
Author

foroughmajidi commented Apr 28, 2020

I solved the above issue (folly/system/threadid.h) with:
#ifdef (CYGWIN)
#include <folly/portability/windows.h>
#endif
But subsequently I faced to this error in(folly/portability/windows.h):

Capture32

If I comment direct.h ,these errors would be occurred:

Capture33

Before all of the above issues I faced to this error:

Capture31

Converting memrchr() to memchr() ,I handled the problem but this is not the correct solution.

What's your suggestion for it?

@Orvid
Copy link
Contributor

Orvid commented Apr 28, 2020

We've not actually tested folly with cygwin or mingw, only MSVC, so there are likely quite a few errors with cygwin and mingw unfortunately.

I have no idea how to deal with the include errors, but for memrchr, just #include <folly/portability/String.h>

@foroughmajidi
Copy link
Author

Thanks for you answer .
I try to build wdt with MSVC, which uses folly.
But why is it expressed that cygwin should be used to build wdt on windows ?
However wdt uses folly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants