Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance issue for AsyncLogWriter with "std::array<std::vector<std::string>, 2> queues" #1398

Open
bluestn opened this issue Jun 24, 2020 · 0 comments

Comments

@bluestn
Copy link

bluestn commented Jun 24, 2020

In AsyncLogWriter class, struct data has "queues" data member, defined as std::array<std::vectorstd::string, 2>, to buffer the output log messages, it's just a FIFO queue.

vector type may cause memory reallocation while data puts into the queue continuously, I think it will be better to change it to list type, to solve this performance issue.

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant