Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

within() timing guarantee #1401

Open
lexuscrossover opened this issue Jun 27, 2020 · 0 comments
Open

within() timing guarantee #1401

lexuscrossover opened this issue Jun 27, 2020 · 0 comments

Comments

@lexuscrossover
Copy link

lexuscrossover commented Jun 27, 2020

Hi,

I am implementing some timeout logic with Facebook folly library's within. I have the following logic:

    CallThatReturnsAFuture().within(std::chrono::milliseconds(10)).onError([](const folly::TimedOut& e){
      //handle the error
    });

I noticed that sometimes, when the CallThatReturnsAFuture() can return in 12 milliseconds, let's say; but the onError lambda does not get invoked. I am wondering what the timing guarantee is for within().

Thank you very much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant