Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packit PR for rpm-build copr build failures, please take a look #2082

Closed
ahornby opened this issue Oct 15, 2023 · 4 comments
Closed

packit PR for rpm-build copr build failures, please take a look #2082

ahornby opened this issue Oct 15, 2023 · 4 comments

Comments

@ahornby
Copy link
Contributor

ahornby commented Oct 15, 2023

https://pagure.io/meta/folly/pull-request/1 removes a patch that is failing to apply and breaking the COPR builds in github actions

@ahornby
Copy link
Contributor Author

ahornby commented Mar 1, 2024

@Orvid is fixing rpm build via pagure the right place to raise the PR?

@Orvid
Copy link
Contributor

Orvid commented Mar 1, 2024

I don't actually appear to have access to that, but that is probably the right location. Give me a bit to figure out who actually has access to be able to merge that.

@Orvid
Copy link
Contributor

Orvid commented Mar 7, 2024

I've found the right person to merge it, but they're currently on holiday so it may be a bit before it can be merged.

@Orvid
Copy link
Contributor

Orvid commented Mar 21, 2024

It took a bit to get feedback, but the end result is that the rpm builds that were configured to run on PRs were not how we're actually handling the package. Instead there's one that's unified fully upstream: https://src.fedoraproject.org/rpms/folly/blob/rawhide/f/folly.spec

TLDR: the PR on pagure would have fixed the issues that were being seen, but we weren't actually using the pagure build to begin with, so the pagure build was removed entirely in 57f719c .

@Orvid Orvid closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants