Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folly fails to build on Windows 11 with build.bat and getdeps.py scripts. #2108

Open
damart25 opened this issue Dec 18, 2023 · 0 comments
Open

Comments

@damart25
Copy link

damart25 commented Dec 18, 2023

I am using Visual Studio 2017 as it the one shown in the comment in buildopts.py.

Error:

$ python3 ./build/fbcode_builder/getdeps.py --allow-system-packages build --scratch-path=C:\Users\user\Downloads\folly
Building on {distro=None, distro_vers=10, fb=off, fbsource=off, os=windows, shared_libs=off, test=on}
Testing ENV[BOOST_ROOT_1_69_0]: None
Testing ENV[BOOST_ROOT_1_69_0]: None
Assessing boost...
Assessing libsodium...
Assessing ninja...
Assessing cmake...
Assessing double-conversion...
Assessing fmt...
Assessing gflags...
Assessing glog...
Assessing googletest...
Assessing lz4...
Assessing perl...
Assessing openssl...
Assessing snappy...
Assessing zlib...
Assessing zstd...
Assessing libevent...
Assessing folly...
Building folly...
...
FAILED: CMakeFiles/bit_iterator_test.dir/folly/container/test/BitIteratorTest.cpp.obj 
C:\PROGRA~2\MICROS~2\2017\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe  /nologo /TP -DBOOST_ATOMIC_NO_LIB -DBOOST_CHRONO_NO_LIB -DBOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DFOLLY_XLOG_STRIP_PREFIXES=\"C:/Users/user/folly:C:/Users/user/Downloads/folly/build/folly\" -DGFLAGS_IS_A_DLL=1 -DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DWIN32_LEAN_AND_MEAN -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_SCL_SECURE_NO_WARNINGS -D_STL_EXTRA_DISABLED_WARNINGS="4774 4987" -IC:\Users\user\folly -I. -IC:\Users\user\Downloads\folly\installed\double-conversion-JnZgRZ4L4DA6Celt5BRXZaeBBSWIEhbK2EDzBa00_ok\include -IC:\Users\user\Downloads\folly\installed\glog-IT0d5MAKCT5N0_levJB1GiWMo6-kJ9-dw-3oS8iT__I\include -IC:\Users\user\Downloads\folly\installed\libevent-9yzlLrhdwfOmOX3H3hhK3bo2TXRlc9lL44SCChflyWc\include -IC:\Users\user\Downloads\folly\installed\zlib-Pvw6c-75LDpAseAAKYg7XacL_IVVtHswE7Tr1xwJNEQ\include -IC:\Users\user\Downloads\folly\installed\openssl-c7qzcSsSvdbOFr8SEi73kUD0bWwnoJzy-DcTSlXyH58\include -IC:\Users\user\Downloads\folly\installed\lz4-_Q9c0HM-d1PbmQkSXZPD9tfiLjcVbpJhFhwiGaRAYYE\include -IC:\Users\user\Downloads\folly\installed\zstd-jOFdacnHiB5DDZLA7VaZTNCkvl9T2gOZT5XULeg49tU\include -IC:\Users\user\Downloads\folly\installed\snappy-7q_lxDNzR4jp5FLEnkqFCBTsA-s8IrUD6PKlwZ7aAc4\include -IC:\Users\user\Downloads\folly\installed\googletest--mkTSB2Z3SXDs7LvCLNxFCs0HYkG_J19fVhJl6A7CLM\include -IC:\Users\user\Downloads\folly\installed\boost-2tB9FYpEGjh-IlTqU0iWl3V-w_R0Vrr09VnBEZRu0h4\include\boost-1_83 -IC:\Users\user\Downloads\folly\installed\gflags-hFoyGsQ3VuepnY6wFN4GZjMu1K_O__epzurAPwouSvo\include -IC:\Users\user\Downloads\folly\installed\fmt-KGNKaqRVNBtAte5kx4sO-HP2kWjlWhQdEEyl3tOdt7Y\include /DWIN32 /D_WINDOWS /W3 /GR  /MD /Zi /O2 /Ob1 /DNDEBUG /EHs /GF /Zc:referenceBinding /Zc:rvalueCast /Zc:implicitNoexcept /Zc:strictStrings /Zc:threadSafeInit /Zc:throwingNew /permissive- /std:c++17 /bigobj /favor:blend /Zc:inline /Wall /MP /Gw /Gy /Qpar /Oi /Ot /wd4191 /wd4291 /wd4309 /wd4310 /wd4366 /wd4587 /wd4592 /wd4628 /wd4723 /wd4724 /wd4868 /wd4996 /wd4068 /wd4091 /wd4146 /wd4800 /wd4018 /wd4365 /wd4388 /wd4389 /wd4100 /wd4459 /wd4505 /wd4701 /wd4702 /wd4061 /wd4127 /wd4200 /wd4201 /wd4296 /wd4316 /wd4324 /wd4355 /wd4371 /wd4435 /wd4514 /wd4548 /wd4571 /wd4574 /wd4582 /wd4583 /wd4619 /wd4623 /wd4625 /wd4626 /wd4643 /wd4647 /wd4668 /wd4706 /wd4710 /wd4711 /wd4714 /wd4820 /wd5026 /wd5027 /wd5031 /wd5045 /we4099 /we4129 /we4566 -std:c++17 /showIncludes /FoCMakeFiles\bit_iterator_test.dir\folly\container\test\BitIteratorTest.cpp.obj /FdCMakeFiles\bit_iterator_test.dir\ /FS -c C:\Users\user\folly\folly\container\test\BitIteratorTest.cpp
C:\Users\user\folly\folly/container/detail/BitIteratorDetail.h(80): error C2065: 'ssize_t': undeclared identifier
C:\Users\user\folly\folly/container/detail/BitIteratorDetail.h(82): note: see reference to class template instantiation 'folly::bititerator_detail::BitIteratorBase<BaseIter>' being compiled
C:\Users\user\folly\folly/container/detail/BitIteratorDetail.h(80): error C2923: 'boost::iterators::iterator_adaptor': 'ssize_t' is not a valid template type argument for parameter 'Difference'
C:\Users\user\folly\folly/container/detail/BitIteratorDetail.h(80): error C2062: type 'unknown-type' unexpected
C:\Users\user\folly\folly/container/detail/BitIteratorDetail.h(81): error C2238: unexpected token(s) preceding ';'
C:\Users\user\folly\folly/container/BitIterator.h(114): error C2061: syntax error: identifier 'ssize_t'
C:\Users\user\folly\folly/container/BitIterator.h(151): note: see reference to class template instantiation 'folly::BitIterator<BaseIter>' being compiled
C:\Users\user\folly\folly/lang/Hint-inl.h(22): note: see reference to class template instantiation 'folly::detail::safe_assert_terminate_w<false>' being compiled
C:\Users\user\folly\folly/container/BitIterator.h(144): error C3646: 'distance_to': unknown override specifier
C:\Users\user\folly\folly/container/BitIterator.h(144): error C2059: syntax error: '('
C:\Users\user\folly\folly/container/BitIterator.h(144): error C2334: unexpected token(s) preceding '{'; skipping apparent function body
C:\Users\user\folly\folly/container/BitIterator.h(151): fatal error C1903: unable to recover from previous error(s); stopping compilation
Internal Compiler Error in C:\PROGRA~2\MICROS~2\2017\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe.  You will be prompted to send an error report to Microsoft later.
INTERNAL COMPILER ERROR in 'C:\PROGRA~2\MICROS~2\2017\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe'
    Please choose the Technical Support command on the Visual C++
    Help menu, or open the Technical Support help file for more information
...
[6/795] Building CXX object CMakeFiles\base64_detail_test.dir\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp.obj
FAILED: CMakeFiles/base64_detail_test.dir/folly/detail/base64_detail/tests/Base64SpecialCasesTest.cpp.obj 
C:\PROGRA~2\MICROS~2\2017\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe  /nologo /TP -DBOOST_ATOMIC_NO_LIB -DBOOST_CHRONO_NO_LIB -DBOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DFOLLY_XLOG_STRIP_PREFIXES=\"C:/Users/user/folly:C:/Users/user/Downloads/folly/build/folly\" -DGFLAGS_IS_A_DLL=1 -DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DWIN32_LEAN_AND_MEAN -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_SCL_SECURE_NO_WARNINGS -D_STL_EXTRA_DISABLED_WARNINGS="4774 4987" -IC:\Users\user\folly -I. -IC:\Users\user\Downloads\folly\installed\double-conversion-JnZgRZ4L4DA6Celt5BRXZaeBBSWIEhbK2EDzBa00_ok\include -IC:\Users\user\Downloads\folly\installed\glog-IT0d5MAKCT5N0_levJB1GiWMo6-kJ9-dw-3oS8iT__I\include -IC:\Users\user\Downloads\folly\installed\libevent-9yzlLrhdwfOmOX3H3hhK3bo2TXRlc9lL44SCChflyWc\include -IC:\Users\user\Downloads\folly\installed\zlib-Pvw6c-75LDpAseAAKYg7XacL_IVVtHswE7Tr1xwJNEQ\include -IC:\Users\user\Downloads\folly\installed\openssl-c7qzcSsSvdbOFr8SEi73kUD0bWwnoJzy-DcTSlXyH58\include -IC:\Users\user\Downloads\folly\installed\lz4-_Q9c0HM-d1PbmQkSXZPD9tfiLjcVbpJhFhwiGaRAYYE\include -IC:\Users\user\Downloads\folly\installed\zstd-jOFdacnHiB5DDZLA7VaZTNCkvl9T2gOZT5XULeg49tU\include -IC:\Users\user\Downloads\folly\installed\snappy-7q_lxDNzR4jp5FLEnkqFCBTsA-s8IrUD6PKlwZ7aAc4\include -IC:\Users\user\Downloads\folly\installed\googletest--mkTSB2Z3SXDs7LvCLNxFCs0HYkG_J19fVhJl6A7CLM\include -IC:\Users\user\Downloads\folly\installed\boost-2tB9FYpEGjh-IlTqU0iWl3V-w_R0Vrr09VnBEZRu0h4\include\boost-1_83 -IC:\Users\user\Downloads\folly\installed\gflags-hFoyGsQ3VuepnY6wFN4GZjMu1K_O__epzurAPwouSvo\include -IC:\Users\user\Downloads\folly\installed\fmt-KGNKaqRVNBtAte5kx4sO-HP2kWjlWhQdEEyl3tOdt7Y\include /DWIN32 /D_WINDOWS /W3 /GR  /MD /Zi /O2 /Ob1 /DNDEBUG /EHs /GF /Zc:referenceBinding /Zc:rvalueCast /Zc:implicitNoexcept /Zc:strictStrings /Zc:threadSafeInit /Zc:throwingNew /permissive- /std:c++17 /bigobj /favor:blend /Zc:inline /Wall /MP /Gw /Gy /Qpar /Oi /Ot /wd4191 /wd4291 /wd4309 /wd4310 /wd4366 /wd4587 /wd4592 /wd4628 /wd4723 /wd4724 /wd4868 /wd4996 /wd4068 /wd4091 /wd4146 /wd4800 /wd4018 /wd4365 /wd4388 /wd4389 /wd4100 /wd4459 /wd4505 /wd4701 /wd4702 /wd4061 /wd4127 /wd4200 /wd4201 /wd4296 /wd4316 /wd4324 /wd4355 /wd4371 /wd4435 /wd4514 /wd4548 /wd4571 /wd4574 /wd4582 /wd4583 /wd4619 /wd4623 /wd4625 /wd4626 /wd4643 /wd4647 /wd4668 /wd4706 /wd4710 /wd4711 /wd4714 /wd4820 /wd5026 /wd5027 /wd5031 /wd5045 /we4099 /we4129 /we4566 -std:c++17 /showIncludes /FoCMakeFiles\base64_detail_test.dir\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp.obj /FdCMakeFiles\base64_detail_test.dir\ /FS -c C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp
C:\Users\user\folly\folly/detail/base64_detail/Base64Scalar.h(148): warning C4245: '=': conversion from 'const char' to 'uint8_t', signed/unsigned mismatch
C:\Users\user\folly\folly/detail/base64_detail/Base64Scalar.h(159): warning C4245: '=': conversion from 'const char' to 'uint8_t', signed/unsigned mismatch
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(58): error C2131: expression did not evaluate to a constant
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(60): note: failure was caused by call of undefined function or one not declared 'constexpr'
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(60): note: see usage of 'folly::detail::base64_detail::`anonymous-namespace'::TestCaseOnStack::TestCaseOnStack'
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(196): error C2664: 'char *folly::detail::base64_detail::base64EncodeScalar(const char *,const char *,char *) noexcept': cannot convert argument 1 from 'std::_String_view_iterator<_Traits>' to 'const char *'
        with
        [
            _Traits=std::char_traits<char>
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(196): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(214): error C2664: 'folly::detail::base64_detail::Base64DecodeResult folly::detail::base64_detail::base64DecodeScalar(const char *,const char *,char *) noexcept': cannot convert argument 3 from 'std::_Array_iterator<_Ty,1000>' to 'char *'
        with
        [
            _Ty=char
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(217): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(219): error C3536: 'res': cannot be used before it is initialized
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(219): error C2664: 'std::basic_string_view<char,std::char_traits<char>>::basic_string_view(const std::basic_string_view<char,std::char_traits<char>> &) noexcept': cannot convert argument 1 from 'std::_Array_iterator<_Ty,1000>' to 'const char *const '
        with
        [
            _Ty=char
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(219): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(226): error C2512: 'testing::AssertionResult': no appropriate default constructor available
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(226): note: No constructor could take the source type, or constructor overload resolution was ambiguous
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(236): error C2664: 'char *folly::detail::base64_detail::base64URLEncodeScalar(const char *,const char *,char *) noexcept': cannot convert argument 1 from 'std::_String_view_iterator<_Traits>' to 'const char *'
        with
        [
            _Traits=std::char_traits<char>
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(236): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(254): error C2664: 'folly::detail::base64_detail::Base64DecodeResult folly::detail::base64_detail::base64URLDecodeScalar(const char *,const char *,char *) noexcept': cannot convert argument 3 from 'std::_Array_iterator<_Ty,1000>' to 'char *'
        with
        [
            _Ty=char
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(255): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(257): error C3536: 'res': cannot be used before it is initialized
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(257): error C2664: 'std::basic_string_view<char,std::char_traits<char>>::basic_string_view(const std::basic_string_view<char,std::char_traits<char>> &) noexcept': cannot convert argument 1 from 'std::_Array_iterator<_Ty,1000>' to 'const char *const '
        with
        [
            _Ty=char
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(257): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(263): error C2512: 'testing::AssertionResult': no appropriate default constructor available
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(263): note: No constructor could take the source type, or constructor overload resolution was ambiguous
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(321): error C2664: 'char *(const char *,const char *,char *)': cannot convert argument 2 from 'std::_String_view_iterator<_Traits>' to 'const char *'
        with
        [
            _Traits=std::char_traits<char>
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(321): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(321): error C2664: 'char *(const char *,const char *,char *)': cannot convert argument 1 from 'std::_String_view_iterator<_Traits>' to 'const char *'
        with
        [
            _Traits=std::char_traits<char>
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(321): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(333): error C2664: 'char *(const char *,const char *,char *)': cannot convert argument 2 from 'std::_String_view_iterator<_Traits>' to 'const char *'
        with
        [
            _Traits=std::char_traits<char>
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(333): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(333): error C2664: 'char *(const char *,const char *,char *)': cannot convert argument 1 from 'std::_String_view_iterator<_Traits>' to 'const char *'
        with
        [
            _Traits=std::char_traits<char>
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(333): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(390): error C2131: expression did not evaluate to a constant
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(195): note: a non-constant (sub-)expression was encountered
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(543): error C3615: constexpr function 'folly::detail::base64_detail::`anonymous-namespace'::decodingErrorDectionTest' cannot result in a constant expression
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(512): note: failure was because type 'const testing::AssertionResult' is not a literal type
C:\Users\user\Downloads\folly\installed\googletest--mkTSB2Z3SXDs7LvCLNxFCs0HYkG_J19fVhJl6A7CLM\include\gtest/internal/gtest-internal.h(104): note: type 'testing::AssertionResult' is not a literal type because it is not an aggregate type, a closure type, or does not have a constexpr constructor that is not a copy or move constructor
C:\Users\user\Downloads\folly\installed\googletest--mkTSB2Z3SXDs7LvCLNxFCs0HYkG_J19fVhJl6A7CLM\include\gtest/gtest-assertion-result.h(220): note: type 'testing::AssertionResult' is not a literal type because its data member 'message_' is of non-literal type 'std::unique_ptr<std::string,std::default_delete<_Ty>>'
        with
        [
            _Ty=std::string
        ]
C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.16.27023\include\memory(2292): note: type 'std::unique_ptr<std::string,std::default_delete<_Ty>>' is not a literal type because it has a user-defined destructor
        with
        [
            _Ty=std::string
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(512): note: failure was because type 'const testing::AssertionResult' is not a literal type
C:\Users\user\Downloads\folly\installed\googletest--mkTSB2Z3SXDs7LvCLNxFCs0HYkG_J19fVhJl6A7CLM\include\gtest/internal/gtest-internal.h(104): note: type 'testing::AssertionResult' is not a literal type because it is not an aggregate type, a closure type, or does not have a constexpr constructor that is not a copy or move constructor
C:\Users\user\Downloads\folly\installed\googletest--mkTSB2Z3SXDs7LvCLNxFCs0HYkG_J19fVhJl6A7CLM\include\gtest/gtest-assertion-result.h(220): note: type 'testing::AssertionResult' is not a literal type because its data member 'message_' is of non-literal type 'std::unique_ptr<std::string,std::default_delete<_Ty>>'
        with
        [
            _Ty=std::string
        ]
C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.16.27023\include\memory(2292): note: type 'std::unique_ptr<std::string,std::default_delete<_Ty>>' is not a literal type because it has a user-defined destructor
        with
        [
            _Ty=std::string
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(544): error C3615: constexpr function 'folly::detail::base64_detail::`anonymous-namespace'::decodingErrorDectionTest' cannot result in a constant expression
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(512): note: failure was because type 'const testing::AssertionResult' is not a literal type
C:\Users\user\Downloads\folly\installed\googletest--mkTSB2Z3SXDs7LvCLNxFCs0HYkG_J19fVhJl6A7CLM\include\gtest/internal/gtest-internal.h(104): note: type 'testing::AssertionResult' is not a literal type because it is not an aggregate type, a closure type, or does not have a constexpr constructor that is not a copy or move constructor
C:\Users\user\Downloads\folly\installed\googletest--mkTSB2Z3SXDs7LvCLNxFCs0HYkG_J19fVhJl6A7CLM\include\gtest/gtest-assertion-result.h(220): note: type 'testing::AssertionResult' is not a literal type because its data member 'message_' is of non-literal type 'std::unique_ptr<std::string,std::default_delete<_Ty>>'
        with
        [
            _Ty=std::string
        ]
C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.16.27023\include\memory(2292): note: type 'std::unique_ptr<std::string,std::default_delete<_Ty>>' is not a literal type because it has a user-defined destructor
        with
        [
            _Ty=std::string
        ]
C:\Users\user\folly\folly\detail\base64_detail\tests\Base64SpecialCasesTest.cpp(512): note: failure was because type 'const testing::AssertionResult' is not a literal type
C:\Users\user\Downloads\folly\installed\googletest--mkTSB2Z3SXDs7LvCLNxFCs0HYkG_J19fVhJl6A7CLM\include\gtest/internal/gtest-internal.h(104): note: type 'testing::AssertionResult' is not a literal type because it is not an aggregate type, a closure type, or does not have a constexpr constructor that is not a copy or move constructor
C:\Users\user\Downloads\folly\installed\googletest--mkTSB2Z3SXDs7LvCLNxFCs0HYkG_J19fVhJl6A7CLM\include\gtest/gtest-assertion-result.h(220): note: type 'testing::AssertionResult' is not a literal type because its data member 'message_' is of non-literal type 'std::unique_ptr<std::string,std::default_delete<_Ty>>'
        with
        [
            _Ty=std::string
        ]
C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.16.27023\include\memory(2292): note: type 'std::unique_ptr<std::string,std::default_delete<_Ty>>' is not a literal type because it has a user-defined destructor
        with
        [
            _Ty=std::string
        ]
...
[9/795] Building CXX object CMakeFiles\sparse_byte_set_benchmark.dir\folly\container\test\SparseByteSetBenchmark.cpp.obj
FAILED: CMakeFiles/sparse_byte_set_benchmark.dir/folly/container/test/SparseByteSetBenchmark.cpp.obj 
C:\PROGRA~2\MICROS~2\2017\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe  /nologo /TP -DBOOST_ATOMIC_NO_LIB -DBOOST_CHRONO_NO_LIB -DBOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DFOLLY_XLOG_STRIP_PREFIXES=\"C:/Users/user/folly:C:/Users/user/Downloads/folly/build/folly\" -DGFLAGS_IS_A_DLL=1 -DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DWIN32_LEAN_AND_MEAN -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_SCL_SECURE_NO_WARNINGS -D_STL_EXTRA_DISABLED_WARNINGS="4774 4987" -IC:\Users\user\folly -I. -IC:\Users\user\Downloads\folly\installed\double-conversion-JnZgRZ4L4DA6Celt5BRXZaeBBSWIEhbK2EDzBa00_ok\include -IC:\Users\user\Downloads\folly\installed\glog-IT0d5MAKCT5N0_levJB1GiWMo6-kJ9-dw-3oS8iT__I\include -IC:\Users\user\Downloads\folly\installed\libevent-9yzlLrhdwfOmOX3H3hhK3bo2TXRlc9lL44SCChflyWc\include -IC:\Users\user\Downloads\folly\installed\zlib-Pvw6c-75LDpAseAAKYg7XacL_IVVtHswE7Tr1xwJNEQ\include -IC:\Users\user\Downloads\folly\installed\openssl-c7qzcSsSvdbOFr8SEi73kUD0bWwnoJzy-DcTSlXyH58\include -IC:\Users\user\Downloads\folly\installed\lz4-_Q9c0HM-d1PbmQkSXZPD9tfiLjcVbpJhFhwiGaRAYYE\include -IC:\Users\user\Downloads\folly\installed\zstd-jOFdacnHiB5DDZLA7VaZTNCkvl9T2gOZT5XULeg49tU\include -IC:\Users\user\Downloads\folly\installed\snappy-7q_lxDNzR4jp5FLEnkqFCBTsA-s8IrUD6PKlwZ7aAc4\include -IC:\Users\user\Downloads\folly\installed\googletest--mkTSB2Z3SXDs7LvCLNxFCs0HYkG_J19fVhJl6A7CLM\include -IC:\Users\user\Downloads\folly\installed\boost-2tB9FYpEGjh-IlTqU0iWl3V-w_R0Vrr09VnBEZRu0h4\include\boost-1_83 -IC:\Users\user\Downloads\folly\installed\gflags-hFoyGsQ3VuepnY6wFN4GZjMu1K_O__epzurAPwouSvo\include -IC:\Users\user\Downloads\folly\installed\fmt-KGNKaqRVNBtAte5kx4sO-HP2kWjlWhQdEEyl3tOdt7Y\include /DWIN32 /D_WINDOWS /W3 /GR  /MD /Zi /O2 /Ob1 /DNDEBUG /EHs /GF /Zc:referenceBinding /Zc:rvalueCast /Zc:implicitNoexcept /Zc:strictStrings /Zc:threadSafeInit /Zc:throwingNew /permissive- /std:c++17 /bigobj /favor:blend /Zc:inline /Wall /MP /Gw /Gy /Qpar /Oi /Ot /wd4191 /wd4291 /wd4309 /wd4310 /wd4366 /wd4587 /wd4592 /wd4628 /wd4723 /wd4724 /wd4868 /wd4996 /wd4068 /wd4091 /wd4146 /wd4800 /wd4018 /wd4365 /wd4388 /wd4389 /wd4100 /wd4459 /wd4505 /wd4701 /wd4702 /wd4061 /wd4127 /wd4200 /wd4201 /wd4296 /wd4316 /wd4324 /wd4355 /wd4371 /wd4435 /wd4514 /wd4548 /wd4571 /wd4574 /wd4582 /wd4583 /wd4619 /wd4623 /wd4625 /wd4626 /wd4643 /wd4647 /wd4668 /wd4706 /wd4710 /wd4711 /wd4714 /wd4820 /wd5026 /wd5027 /wd5031 /wd5045 /we4099 /we4129 /we4566 -std:c++17 /showIncludes /FoCMakeFiles\sparse_byte_set_benchmark.dir\folly\container\test\SparseByteSetBenchmark.cpp.obj /FdCMakeFiles\sparse_byte_set_benchmark.dir\ /FS -c C:\Users\user\folly\folly\container\test\SparseByteSetBenchmark.cpp
C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.16.27023\include\random(2401): error C2338: invalid template argument for uniform_int_distribution: N4659 29.6.1.1 [rand.req.genl]/1e requires one of short, int, long, long long, unsigned short, unsigned int, unsigned long, or unsigned long long
C:\Users\user\folly\folly\container\test\SparseByteSetBenchmark.cpp(75): note: see reference to class template instantiation 'std::uniform_int_distribution<unsigned char>' being compiled
C:\Users\user\folly\folly/Range.h(1497): note: see reference to class template instantiation 'folly::Range<const char *>' being compiled
C:\Users\user\folly\folly/lang/Hint-inl.h(22): note: see reference to class template instantiation 'folly::detail::safe_assert_terminate_w<false>' being compiled
C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.16.27023\include\random(2401): error C2338: note: char, signed char, unsigned char, int8_t, and uint8_t are not allowed
ninja: build stopped: subcommand failed.
Command '['C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Professional\\VC\\Auxiliary\\Build\\vcvarsall.bat', 'amd64', '&&', 'C:\\Users\\user\\Downloads\\folly\\installed\\cmake-m0JOc_HUfrC-84lOdCNWLHb6mxlcRjVgcf0qsipTRyM\\bin\\cmake.exe', '--build', 'C:\\Users\\user\\Downloads\\folly\\build\\folly', '--target', 'install', '--config', 'Release', '-j', '7']' returned non-zero exit status 1.
!! Failed

Repro:

Fresh Windows 11 install, installed Visual Studio 2017 and run either the build.bat or python3 ./build/fbcode_builder/getdeps.py --allow-system-packages build --scratch-path=C:\Users\user\Downloads\folly.

My MSVC version seems to be:
The CXX compiler identification is MSVC 19.16.27051.0

Is there anything I'm missing for building folly on windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant