Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master build broken on Windows with ninja #604

Closed
KindDragon opened this issue May 25, 2017 · 11 comments
Closed

Master build broken on Windows with ninja #604

KindDragon opened this issue May 25, 2017 · 11 comments
Assignees

Comments

@KindDragon
Copy link
Contributor

Tag v2017.05.08.00 was fine, but master is broken

c1xx: fatal error C1083: Cannot open source file: '4987 -ID:\Work\vcpkg\buildtrees\folly\src\head\folly-master -I. -ID:\Work\vcpkg\installed\x64-windows\include -ID:\Work\vcpkg\installed\x64-windows\Include /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP /MD /O2 /Oi /Gy /DNDEBUG /Zi   /EHa /Zc:referenceBinding /Zc:rvalueCast /Zc:implicitNoexcept /Zc:strictStrings /Zc:threadSafeInit /Zc:throwingNew /std:c++latest /permissive- /bigobj /favor:blend /Zc:inline /Wall /MP /GF /Gw /Gy /Qpar /Oi /Ot /wd4191 /wd4291 /wd4309 /wd4310 /wd4366 /wd4587 /wd4592 /wd4723 /wd4724 /wd4868 /wd4996 /wd4068 /wd4091 /wd4146 /wd4800 /wd4018 /wd4365 /wd4388 /wd4389 /wd4100 /wd4459 /wd4505 /wd4701 /wd4702 /wd4061 /wd4127 /wd4200 /wd4201 /wd4296 /wd4316 /wd4324 /wd4355 /wd4371 /wd4435 /wd4514 /wd4548 /wd4574 /wd4582 /wd4583 /wd4619 /wd4623 /wd4625 /wd4626 /wd4647 /wd4668 /wd4706 /wd4710 /wd4711 /wd4714 /wd4820 /wd5026 /wd5027 /wd5031 /we4099 /we4129 /we4566 /showIncludes /FoCMakeFiles\folly_base.dir\folly\Demangle.cpp.obj /FdCMakeFiles\folly_base.dir\folly_base.pdb /FS -c D:\Work\vcpkg\buildtrees\folly\src\head\folly-master\folly\Demangle.cpp': No such file or directory
@KindDragon
Copy link
Contributor Author

KindDragon commented May 25, 2017

It happened between v2017.05.15.00 and v2017.05.22.00
/cc @Orvid

@Orvid Orvid self-assigned this May 25, 2017
@Orvid
Copy link
Contributor

Orvid commented May 25, 2017

Looking. I generally only test with the Visual Studio backend, so it's perfectly possible I broke other things in the process.

@KindDragon
Copy link
Contributor Author

I just prefer Ninja because it's usually much faster. It would be great if it start working again

@Orvid
Copy link
Contributor

Orvid commented May 25, 2017

So, it appears to be hitting a bug in the CMake Ninja generator that was causing it to generate an escape character in a place it shouldn't have been.

@KindDragon
Copy link
Contributor Author

Could you please create an issue about this? https://gitlab.kitware.com/cmake/cmake/issues

@Orvid
Copy link
Contributor

Orvid commented May 26, 2017

I need to put together a better-isolated use-case, but yes, I planned to open an issue upstream for it.

@KindDragon
Copy link
Contributor Author

Thank you

@Milerius
Copy link

Milerius commented Dec 7, 2019

Issue still occur we should reopen

@Orvid
Copy link
Contributor

Orvid commented Dec 9, 2019

Please file a new issue with details if this is happening again.

@chaiken
Copy link

chaiken commented Jan 3, 2021

Observed on Unix with master branch at c7166a6. I'll try filing a new issue.

@chenrui333
Copy link

it failed with osx build for the last two releases as well, #1507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants