Issue with status bar transparent

[omainegra]

Description

When the status bar is transparent, Fresco doesn't draw the image underneath it

Reproduction

Just run: https://github.com/omainegra/furry-octo-potato
As an extra, you can toggle the commented code and see how it works with a regular ImageView

Issue

Expected

Update

After playing with it I found that redrawing after ViewCompat.setOnApplyWindowInsetsListener fixes the problem.

ViewCompat.setOnApplyWindowInsetsListener(findViewById<SimpleDraweeView>(R.id.draweeView)) { view, insetsCompat ->
    view.requestLayout()
    insetsCompat
} 

Additional Information

• Fresco version: 1.11.0
• Platform version: [{ Nexus 6P, Android 8.1 }, { Pixel 3, Android 9 }]

[lambdapioneer]

Hi @omainegra ! Thank you for the excellently crafted issue :)

I think this is undesired behaviour, but I do not know the best place to fix this. @oprisnik might have an intuitive idea.

I will mark this as a good starting issue to encourage community contributions :) it's probably not making it into our high-priority list for day-to-day fixes.

[iadeelzafar]

@lambdapioneer @oprisnik I'd love to take on this issue. Can you guys give some more context on how this could be resolved?

[oprisnik]

Hey! Awesome, there's a sample in the first post here. So you can patch that and then fix the issue where the status bar is not properly considered, see other comments.