Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haxl failing to compile with ghc-8.2 rc2 #70

Closed
ersran9 opened this issue May 18, 2017 · 6 comments
Closed

haxl failing to compile with ghc-8.2 rc2 #70

ersran9 opened this issue May 18, 2017 · 6 comments

Comments

@ersran9
Copy link

ersran9 commented May 18, 2017

While trying to compile with ghc-8.2

    /tmp/stack12680/haxl-0.5.0.0/Haxl/Core/Types.hs:112:1: error:
        Could not find module ‘Data.Typeable.Internal’
        it is a hidden module in the package ‘base-4.10.0.0’
        Use -v to see a list of the files searched for.
        |
    112 | import Data.Typeable.Internal
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Replacing the import with Data.Typeable seemed to fix the issue.

compiler : The Glorious Glasgow Haskell Compilation System, version 8.2.0.20170507

@ersran9 ersran9 changed the title haxl failing to compile with ghc-8.2 rc haxl failing to compile with ghc-8.2 rc2 May 18, 2017
niteria added a commit to niteria/Haxl that referenced this issue May 18, 2017
@ersran9
Copy link
Author

ersran9 commented May 18, 2017

There's one more location with the same issue, in Haxl.Core.DataCache.

sreenidhi:~/Work/Haxl $ git diff
diff --git a/Haxl/Core/DataCache.hs b/Haxl/Core/DataCache.hs
index c40f092..aa2f3b9 100644
--- a/Haxl/Core/DataCache.hs
+++ b/Haxl/Core/DataCache.hs
@@ -28,7 +28,7 @@ import Data.Hashable
 import Prelude hiding (lookup)
 import Unsafe.Coerce
 import qualified Data.HashMap.Strict as HashMap
-import Data.Typeable.Internal
+import Data.Typeable
 import Data.Maybe
 #if __GLASGOW_HASKELL__ < 710
 import Control.Applicative ((<$>))
diff --git a/Haxl/Core/Types.hs b/Haxl/Core/Types.hs
index ef1bb5a..afb7279 100644
--- a/Haxl/Core/Types.hs
+++ b/Haxl/Core/Types.hs
@@ -110,7 +110,7 @@ import Data.List (intercalate, sortBy)
 import Data.Map (Map)
 import qualified Data.Map as Map
 import Data.Text (Text, unpack)
-import Data.Typeable.Internal
+import Data.Typeable
 
 import Haxl.Core.Exception
 #if __GLASGOW_HASKELL__ < 708

@ersran9
Copy link
Author

ersran9 commented May 18, 2017

Thanks!

@niteria
Copy link
Contributor

niteria commented May 18, 2017

Thanks for the report!

@phadej
Copy link
Contributor

phadej commented Jul 25, 2017

Are there any plans when new version will be released? https://matrix.hackage.haskell.org/package/haxl <- red with GHC-8.2 still

facebook-github-bot pushed a commit that referenced this issue Jul 25, 2017
Summary:
We need a release for GHC 8.2.1 compatibility:
#70

(Note: this ignores all push blocking failures!)

Reviewed By: simonmar

Differential Revision: D5488485

fbshipit-source-id: 61ae115e7456beb1dd8855d387690e13a1e09bdc
@niteria
Copy link
Contributor

niteria commented Jul 25, 2017

http://hackage.haskell.org/package/haxl-0.5.1.0 has been released on hackage.

@phadej
Copy link
Contributor

phadej commented Jul 25, 2017

@niteria thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants