Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for top level await #1352

Open
ayroblu opened this issue Mar 15, 2024 · 1 comment
Open

Support for top level await #1352

ayroblu opened this issue Mar 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ayroblu
Copy link

ayroblu commented Mar 15, 2024

Bug Description

Top level await breaks hermes parser

await Promise.resolve()

The Expected Behavior

Top level await is common in certain scenarios, it should be supported at the parser level
@ayroblu ayroblu added the bug Something isn't working label Mar 15, 2024
@tmikov
Copy link
Contributor

tmikov commented Mar 15, 2024

That is a good catch. I don't think the parser has a way of understanding the script/module distinction. This might require changing the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ayroblu @tmikov