Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store as global object is not working on debugger #583

Closed
1 task
numandev1 opened this issue Aug 27, 2021 · 3 comments
Closed
1 task

store as global object is not working on debugger #583

numandev1 opened this issue Aug 27, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@numandev1
Copy link

Bug Description

image

  • I have run gradle clean and confirmed this bug does not occur with JSC

Hermes version: 0.7.2
React Native version (if any): 0.64.2
OS version (if any): Big Sur
Platform (most likely one of arm64-v8a, armeabi-v7a, x86, x86_64): all

Steps To Reproduce

  1. open hermes degger from fliiper
  2. then right mouse click on any object of console.log and click on store as global object it will not store as global object

code example:

The Expected Behavior

when i click on store as global object it should store that object in temp variable and should be copy by copy()

@numandev1 numandev1 added the bug Something isn't working label Aug 27, 2021
@avp
Copy link
Contributor

avp commented Aug 27, 2021

This requires supporting Runtime.callFunctionOn in the Hermes debugger API, which is a Chrome debugger protocol message that we don't have set up right now.

Thanks for the report, we'll look into implementing this.

@avp avp added enhancement New feature or request and removed bug Something isn't working labels Aug 27, 2021
@numandev1
Copy link
Author

@avp is there any chance to add this enhancement?

@jpporto
Copy link
Contributor

jpporto commented Feb 2, 2022

Hi. This has been merged back in the react native repository (which is Hermes' CDP implementation's home).

@jpporto jpporto closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants