New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Native App crashes after splash screen when Hermes is enabled #69
Comments
The |
07-30 09:43:42.911 13712 13712 I crash_dump64: performing dump of process 13463 (target tid = 13604) |
Having the same issue, but only on non-debug builds. |
@tarasvakulka can you explain why you closed the issue? If you can, please provide some context here about how it was resolved so that anyone in the future with this issue will know what they should do. |
@dulinriley, problem was not in hermes, my method array sort worked incorrect and hermesvm throw error, I refactor my code and now my problem solved |
I am facing this same issue, if hermes is disabled in android/build.gradle then my app works fine but if hermes is enabled then I get error after splash screen "maximum call stack reached, js engines hermes". Note: I have also run gradle clean |
It should be noted that there is a bug with the array sort function in Hermes. #95 I had an issue where my comparator callback function in an array sort was incorrect. JavaScript engines usually fallback to the default implementation in that case, but Hermes doesn't and gets stuck in an infinite loop. Pretty understandable bug on Hermes' part, especially considering how new it is. Fixing my comparator function solved the issue for me. |
@jasonalmaturner You are right, this is bug of Hermes, I hope Hermes team fix this in future, because I spent a lot of time to find this problem in infinity loop if Hermes is on |
@tarasvakulka we realize that this is a problem and we are working on fixing it. Unfortunately it isn't a simple fix, but we will address it. Thank you for your understanding! |
I build my app bundle for Play Store with Helmet and only shows the splash, after crash. |
Should this issue be reopened? Fixing js is a workaround - it should just work. @tmikov is there are version with a fix? |
@neildhar I'm on version 0.4.3
Using react-native 0.62.3. I guess I just need to upgrade. Thanks! |
Merge facebook/hermes with tag v0.11.0
React Native version:
0.60.4
Enabled Hermes
Crash on release android build after splash screen
07-29 14:06:59.334 21833 21833 F DEBUG : #00 pc 000000000001a170 /data/app/app.theMovieExpert-wKzSD-OkiRBPXzh7GD8Acw==/lib/arm64/libhermes.so (facebook::hermes::detail::hermesFatalErrorHandler(void*, std::__ndk1::basic_string<char, std::__ndk1::char_traits, std::__ndk1::allocator> const&, bool)+28)
07-29 14:07:00.136 749 749 I Zygote : Process 21790 exited due to signal (9)
The text was updated successfully, but these errors were encountered: