Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it worth to use different js engine on android? #79

Closed
punksta opened this issue Aug 2, 2019 · 2 comments
Closed

Is it worth to use different js engine on android? #79

punksta opened this issue Aug 2, 2019 · 2 comments

Comments

@punksta
Copy link

punksta commented Aug 2, 2019

I am wondering about long-term plans and motivation of creating hermes.

Application startup time and apk size are very important, but compatibility across platforms is very important as well.

It took core team a while to bring up-to-date release of JSC to android using https://github.com/react-native-community/jsc-android-buildscripts in core. And both platforms are using more or less same version of webkit now.

Hermes works in a different way (bite-code generation), uses different bundle format and does not support all js features supported by JSC. I think RN on android is less stable(facebook/react-native#21755, facebook/react-native#24261, facebook/react-native#15059) then IOS due to larger device and OS diversity. New engine potentially contains even more bugs sine it's very new. Also it might not properly work with existing crash report tools, code-push like things and any other tools which uses reflection/js modification in the runtime due to different format of bundle.

Considering all things above I want to ask, is it really worth to try and what are facebook long-term plans about this engine.

@mhorowitz
Copy link
Contributor

Thanks for your question! This is pretty fundamental for our reasons for working on Hermes.

Facebook is committed to Hermes. Most of our Android React Native apps have already switched to use Hermes, some more than a year ago, and it has provided significant value for us. We have a significant number of people running RN apps on Android. We run tests continuously and track reliability metrics across all platforms. For open source React Native, Hermes is still opt-in. We recognize that it’s a big change, and we want to work with the community to determine if and when it’s right to make Hermes the default. We welcome any issues and PRs around engine inconsistencies. For developers who strongly value compatibility, they will be able to continue using JSC on Android as long as the community keeps maintaining it.

@ishigo1987
Copy link

Or for Android you can replace JavascriptCore by J2V8
https://github.com/eclipsesource/J2V8

mganandraj pushed a commit to mganandraj/hermes that referenced this issue Jun 22, 2022
Bump version to test internal pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants