You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using jsc, the functions can be generated correctly:
However, using hermes, we got an error, presumably because the function has already been compiled to bytecode, and the generated function can't make use of it:
Problem
The hermes engine is incompatible with numjs, which uses cwise library for generate cache efficient map/reduce operations.
When using
numjs
, some functions are dynamically generated by the library based on the dimensions of arguments provided.For example, for the
unpack
function here reproduced below:When using
jsc
, the functions can be generated correctly:However, using
hermes
, we got an error, presumably because the function has already been compiled to bytecode, and the generated function can't make use of it:Sample error for search indexing:
Solution
Using
jsc
can be a walkaround but withhermes
going to be default, I hope this issue can be addressed withhermes
.Some ideas:
hermes
provides some ability to opt out / exclude bytecode for certain functions?numjs
andcwise
lib to make it compatible with the wayhermes
work now?Any help on this issue would be appreciated.
Additional Context
Here's the relevant code for compiling and generating dynamic function in
cwise-compiler
:https://github.com/scijs/cwise-compiler/blob/b65933f021302e15c6d4624353bb4b69168cd543/lib/compile.js#L116-L199
The text was updated successfully, but these errors were encountered: