Skip to content

Commit

Permalink
turn off HHIRInlineFrameOpts
Browse files Browse the repository at this point in the history
It was causing lots of crashes due to a race between the JIT and the
interpreter during warmup. It is fixed in trunk but porting the trunk
fix over to 3.1 is too much risk.
  • Loading branch information
ptarjan committed May 28, 2014
1 parent 6f6bc07 commit be654dd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hphp/runtime/base/runtime-option.h
Expand Up @@ -441,7 +441,7 @@ class RuntimeOption {
F(uint32_t, HHIRAlwaysInlineMaxCost, 10) \
F(uint32_t, HHIRInliningMaxDepth, 4) \
F(uint32_t, HHIRInliningMaxReturnDecRefs, 3) \
F(bool, HHIRInlineFrameOpts, true) \
F(bool, HHIRInlineFrameOpts, false) \
/* 1 (the default) gives most asserts. 2 adds less commonly \
* useful/more expensive asserts. */ \
F(uint32_t, HHIRGenerateAsserts, debug) \
Expand Down

0 comments on commit be654dd

Please sign in to comment.