Skip to content

Commit

Permalink
Integrate pretty printer
Browse files Browse the repository at this point in the history
Reviewed By: pieterv

Differential Revision: D9981749

fbshipit-source-id: 55ec9a9df81645f3aa21c073f0cec7643a442787
  • Loading branch information
gkz authored and hhvm-bot committed Sep 27, 2018
1 parent 6387060 commit cbbb928
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
7 changes: 7 additions & 0 deletions hphp/hack/src/hhbc/hhbc_options.ml
Expand Up @@ -47,6 +47,7 @@ type t = {
option_enable_reified_generics : bool; option_enable_reified_generics : bool;
option_enable_intrinsics_extension : bool; option_enable_intrinsics_extension : bool;
option_enable_hhjs : bool; option_enable_hhjs : bool;
option_dump_hhjs : bool;
option_phpism_undefined_const_as_string : bool; option_phpism_undefined_const_as_string : bool;
option_phpism_undefined_const_fallback : bool; option_phpism_undefined_const_fallback : bool;
} }
Expand Down Expand Up @@ -89,6 +90,7 @@ let default = {
option_enable_reified_generics = false; option_enable_reified_generics = false;
option_enable_intrinsics_extension = false; option_enable_intrinsics_extension = false;
option_enable_hhjs = false; option_enable_hhjs = false;
option_dump_hhjs = false;
option_phpism_undefined_const_as_string = true; option_phpism_undefined_const_as_string = true;
option_phpism_undefined_const_fallback = true; option_phpism_undefined_const_fallback = true;
} }
Expand Down Expand Up @@ -128,6 +130,7 @@ let disable_return_by_reference o = o.option_disable_return_by_reference
let enable_reified_generics o = o.option_enable_reified_generics let enable_reified_generics o = o.option_enable_reified_generics
let enable_intrinsics_extension o = o.option_enable_intrinsics_extension let enable_intrinsics_extension o = o.option_enable_intrinsics_extension
let enable_hhjs o = o.option_enable_hhjs let enable_hhjs o = o.option_enable_hhjs
let dump_hhjs o = o.option_dump_hhjs
let phpism_undefined_const_as_string o = o.option_phpism_undefined_const_as_string let phpism_undefined_const_as_string o = o.option_phpism_undefined_const_as_string
let phpism_undefined_const_fallback o = o.option_phpism_undefined_const_fallback let phpism_undefined_const_fallback o = o.option_phpism_undefined_const_fallback
let to_string o = let to_string o =
Expand Down Expand Up @@ -253,6 +256,8 @@ let set_option options name value =
{ options with option_disable_return_by_reference = as_bool value} { options with option_disable_return_by_reference = as_bool value}
| "eval.enablehhjs" -> | "eval.enablehhjs" ->
{ options with option_enable_hhjs = as_bool value } { options with option_enable_hhjs = as_bool value }
| "eval.dumphhjs" ->
{ options with option_dump_hhjs = as_bool value }
| "hack.lang.phpism.undefinedconstasstring" -> | "hack.lang.phpism.undefinedconstasstring" ->
{ options with option_phpism_undefined_const_as_string = as_bool value} { options with option_phpism_undefined_const_as_string = as_bool value}
| "hack.lang.phpism.undefinedconstfallback" -> | "hack.lang.phpism.undefinedconstfallback" ->
Expand Down Expand Up @@ -381,6 +386,8 @@ let value_setters = [
fun opts v -> { opts with option_disable_return_by_reference = (v = 1)}); fun opts v -> { opts with option_disable_return_by_reference = (v = 1)});
(set_value "hhvm.enable_hhjs" get_value_from_config_int @@ (set_value "hhvm.enable_hhjs" get_value_from_config_int @@
fun opts v -> { opts with option_enable_hhjs = (v = 1) }); fun opts v -> { opts with option_enable_hhjs = (v = 1) });
(set_value "hhvm.dump_hhjs" get_value_from_config_int @@
fun opts v -> { opts with option_dump_hhjs = (v = 1) });
(set_value "hhvm.hack.lang.phpism.undefined_const_as_string" get_value_from_config_int @@ (set_value "hhvm.hack.lang.phpism.undefined_const_as_string" get_value_from_config_int @@
fun opts v -> { opts with option_phpism_undefined_const_as_string = (v = 1)}); fun opts v -> { opts with option_phpism_undefined_const_as_string = (v = 1)});
(set_value "hhvm.hack.lang.phpism.undefined_const_fallback" get_value_from_config_int @@ (set_value "hhvm.hack.lang.phpism.undefined_const_fallback" get_value_from_config_int @@
Expand Down
1 change: 1 addition & 0 deletions hphp/runtime/base/runtime-option.h
Expand Up @@ -606,6 +606,7 @@ struct RuntimeOption {
F(bool, LogThreadCreateBacktraces, false) \ F(bool, LogThreadCreateBacktraces, false) \
F(bool, FailJitPrologs, false) \ F(bool, FailJitPrologs, false) \
F(bool, EnableHHJS, false) \ F(bool, EnableHHJS, false) \
F(bool, DumpHHJS, false) \
F(bool, UseHHBBC, !getenv("HHVM_DISABLE_HHBBC")) \ F(bool, UseHHBBC, !getenv("HHVM_DISABLE_HHBBC")) \
/* Generate warning of side effect of the pseudomain is called by \ /* Generate warning of side effect of the pseudomain is called by \
top-level code.*/ \ top-level code.*/ \
Expand Down
1 change: 1 addition & 0 deletions hphp/runtime/base/unit-cache.cpp
Expand Up @@ -706,6 +706,7 @@ std::string mangleUnitMd5(const std::string& fileMd5) {
+ (RuntimeOption::RepoDebugInfo ? '1' : '0') + (RuntimeOption::RepoDebugInfo ? '1' : '0')
+ (RuntimeOption::EvalDisableReturnByReference ? '1' : '0') + (RuntimeOption::EvalDisableReturnByReference ? '1' : '0')
+ (RuntimeOption::EvalEnableHHJS ? '1' : '0') + (RuntimeOption::EvalEnableHHJS ? '1' : '0')
+ (RuntimeOption::EvalDumpHHJS ? '1' : '0')
+ (RuntimeOption::UndefinedConstAsString ? '1' : '0') + (RuntimeOption::UndefinedConstAsString ? '1' : '0')
+ std::to_string(RuntimeOption::UndefinedConstFallback) + std::to_string(RuntimeOption::UndefinedConstFallback)
+ mangleUnitPHP7Options() + mangleUnitPHP7Options()
Expand Down

0 comments on commit cbbb928

Please sign in to comment.