DateTimeZone::getTransitions doesn't accept optional parameters

[luizribeiro]

Since PHP 5.3.0, DateTimeZone::getTransitions has been accepting two optional integer parameters: $timestamp_begin and $timestamp_end: http://www.php.net/manual/en/datetimezone.gettransitions.php

HHVM doesn't seem to support it, given that running this on hphpd gives a warning:

  hphpd> =(new DateTimeZone('Atlantic/Azores'))->getTransitions(strtotime('2013'), strtotime('2014'))
  Warning: Too many arguments for DateTimeZone::getTransitions(), expected 0

[kevholmes]

Our application also encounters a similar error due to this issue.

[RyanGerstein]

Getting the exact same error with the following code:

$transitions = (new DateTimeZone("America/New_York"))->getTransitions(new DateTime("2013-01-01"), new DateTime(date("Y")."-12-31"));
    \nWarning: Too many arguments for DateTimeZone::getTransitions(), expected 0

[GreenRover]

I have the same issue

[olvlvl]

Same issue with my DateTime extension:

https://travis-ci.org/ICanBoogie/DateTime/jobs/35008457#L48

[mickhrmweb]

We're also affected, a workaround is in place for us but looking forward to the fix becoming available.

[jackdied]

I've started working on this.

[JoelMarcey]

@jackdied I already have a diff up internally for this.

Internal Diff: D1658643

[JoelMarcey]

I am waiting for the DateTime conversion to HNI before it lands. This is because of some default constants that we need to support that just work better in HNI instead of IDL.

[jackdied]

Ah, I hadn't seen that. I started a similar in D5620779. Keep an eye on that "int timestamp". I didn't get far enough in the task to chase it down but signed int time_t's are an accident waiting to happen.

edit: /differential/diff/5620779/, just a preview so apparently not in the "D" namespace.

[JoelMarcey]

DateTime is now HNI (Yay!!)

I have a new internal diff since I didn't want to go through the rebase process with the HNI conversion

D1724025