Eval.EnableZendZorting/hhvm.enable_zend_zorting needed for some magento extensions

[juliorosier]

Magento website breaks with this module turned on.
In app/etc/modules there are a couple of TBT*.xml files that belong to the module

We found out that if we turn of TBT_RewardsOnly.xml. the problem is fixed.
But off course that is not a beautiful option.

Also there is a calculation issue when updating product amount in shopping cart
from lets say 1 to 3 the subtotal stays at the price of 1 piece.

Using Rubic_FixTotalSorting. does not fix this problem

thanks

[csdougliss]

It might be helpful if you can include some error logs!

[danslo]

Instead of using that module, use -vEval.EnableZendSorting=1 on a recent build (try nightly). Also clear your caches afterwards, magento caches totals.

[csdougliss]

@danslo out of interest what is the related ini setting for it, as the documentation on the wiki is out of date. Thanks

[danslo]

@craigcarnell There isn't one (yet). Add it to your config.hdf.

[csdougliss]

@danslo OK. I've stopped using config.hdf! :)

[fredemmott]

Depending on which API was used, we might automatically have one - in which case, it'll be hhvm.enable_zend_sorting

[csdougliss]

@fredemmott Thanks - I recently setup the admin server for hhvm but I don't see where I can get a list of all current ini settings applied - is this something that could be done? Thanks

[fredemmott]

https://github.com/facebook/hhvm/wiki/INI%20Settings is the most complete list. ini_get_all() will give you some of the current values. This is something we need to improve.

[csdougliss]

@fredemmott Thanks I've added a simple dump script to my application.

["hhvm.enable_zend_sorting"]=>
  array(3) {
    ["global_value"]=>
    string(0) ""
    ["local_value"]=>
    string(0) ""
    ["access"]=>
    int(4)
  }

👍

[fredemmott]

@danslo: the sort order is undefined; does magento itself depend on PHP5's behavior, or is it just some extensions?

[danslo]

@fredemmott Yes, it's Magento itself... but third party extensions may also suffer from it as they can add themselves to the totals collector (like a reward point module).

Anyway, Eval.EnableZendSorting should always be enabled for Magento. I did a PR earlier to add it as an ini setting (#2850) but apparently @ptarjan was working on ini stuff at that point. Maybe it should be reopened / put up for review again.

[fredemmott]

@danslo : I've replied on #2850 - it already works as an ini setting.

[danslo]

👍

[fredemmott]

Given this is in doc/inconsistencies, I don't think there is anything more we should do it within HHVM. It might be worthwhile to file an issue against Magento's installation documentation.

[Majkl578]

@fredemmott: Maybe default to off when not in EnableHipHopSyntax mode?

[fredemmott]

@Majkl578 : we decided not to do that as the PHP documentation explicitly says this behavior is undefined and shouldn't be depended on, and it's not performant.

[rossmc]

@danslo I tried adding both hhvm.EnableZendSorting = 1 and -vEval.EnableZendSorting=1 to both my /etc/hhvm/php.ini file or /etc/hhvm/server.ini file. I cleared the cache, re-indexed and tested with the default design package. I have Magento 1.9.

Neither worked but your Rubic_FixTotalSorting module did. I would prefer to use the recommened EnableZendSorting solution, am I implementing it correctly?

[danslo]

@rossmc In ini files it should be hhvm.enable_zend_sorting = 1. Also don't forget to restart HHVM and clear mage to cachrs as it caches sort orders.

[rossmc]

@danslo,thanks I'll try that tomorrow. Should it be in both ini files? /etc/hhvm/php.ini file and /etc/hhvm/server.ini file

[danslo]

Either should be fine. Php.ini is used for both the server and command line.

[rossmc]

@danslo hhvm.enable_zend_sorting = 1 fixed the issue I had with magento adding up tax totals correctly but I'm still having an issue with the sorting of currency rates.
http://magento.stackexchange.com/questions/76727/hhvm-is-breaking-display-in-manage-currency-rates

[danslo]

Separate issue for sure, if I had to guess it probably has something to do with this inconsistency. Can't exactly say I have a lot of time to investigate this issue though. It would help if someone could narrow it down to a couple lines of PHP (outside of Magento).

[danslo]

I also cannot reproduce this on the latest nightly, so please provide exact instructions.

[rossmc]

@danslo I created a new issue for this, can you check if I have enough details provided in it? I tried too add as much as I could think of.