[HackC] class constant/enum shape keys are not namespace-aware

[fredemmott]

HHVM Version

3.26.0

Operating System and Version

MacOS High Sierra

Standalone code, or other way to reproduce the problem

<?hh

namespace MyNS;

enum MyEnum: string {
  FOO = 'Herp';
}

type MyShape = shape(
  MyEnum::FOO => string,
);

type_structure(MyShape::class);

Expected result

No error (this is the case with HackC disabled)

Actual result

$ hhvm test.php

Fatal error: Uncaught Error: resolving type alias MyNS\MyShape failed. Have you declared all classes in the type alias in /private/tmp/hhtest/test.php:13
Stack trace:
#0 /private/tmp/hhtest/test.php(13): HH\type_structure()
#1 {main}

Extra: HHAS diff

$ hhvm -v Eval.DumpHhas=1 test.php > hackc.hhas
$ hhvm -v Eval.HackCompilerDefault=false -v Eval.DumpHhas=1 test.php > hphpc.hhas
$ diff -u hphpc.hhas hackc.hhas
--- hphpc.hhas	2018-05-10 11:58:39.000000000 -0700
+++ hackc.hhas	2018-05-10 11:58:29.000000000 -0700
@@ -7,13 +7,13 @@
 .hh_file 1;

 .main (1,1) {
-  .srcloc 5:1,5:1;
+  .srcloc 5:6,5:11;
   DefCls 0
-  .srcloc 9:1,11:2;
+  .srcloc 9:6,9:12;
   DefTypeAlias 0
   .srcloc 13:1,13:30;
   FPushFuncU 1 "HH\\type_structure" "type_structure"
-  .srcloc 13:16,13:29;
+  .srcloc 13:16,13:22;
   String "MyNS\\MyShape"
   .srcloc 13:1,13:30;
   FPassCE 0 Cell
@@ -29,5 +29,5 @@
   .const FOO = """s:4:\"Herp\";""";
 }

-.alias MyNS\MyShape = <"HH\\darray"  > """Y:2:{s:4:\"kind\";i:14;s:6:\"fields\";Y:1:{s:16:\"MyNS\\MyEnum::FOO\";Y:2:{s:10:\"is_cls_cns\";b:1;s:5:\"value\";Y:1:{s:4:\"kind\";i:4;}}}}""";
+.alias MyNS\MyShape = <"HH\\darray"  > """Y:2:{s:4:\"kind\";i:14;s:6:\"fields\";Y:1:{s:11:\"MyEnum::FOO\";Y:2:{s:10:\"is_cls_cns\";b:1;s:5:\"value\";Y:1:{s:4:\"kind\";i:4;}}}}""";
 # /private/tmp/hhtest/test.php ends here

[fredemmott]

This blocks updating docs.hhvm.com