Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heapgraph sampling and visualization tooling #8623

Open
andrewjtimmons opened this issue Dec 6, 2019 · 9 comments
Open

Heapgraph sampling and visualization tooling #8623

andrewjtimmons opened this issue Dec 6, 2019 · 9 comments

Comments

@andrewjtimmons
Copy link

andrewjtimmons commented Dec 6, 2019

HHVM Version

hhvm --version
HipHop VM 4.13.2 (rel)

hh_client --version
hackc-a6fd900a34a498abea492c9bcb9045ee5e9cb7f3-4.13.2

Heapgraph visualization and sampling

It would be great to have tooling that could sample a heapgraph and then output data and stacks that could be visualized in an icicle format, similar to an inverted flamegraph created by Xenon. I spoke with Kendall Hopkins and he suggested tooling and visualizations might exist.

https://github.com/facebook/hhvm/tree/master/hphp/runtime/ext/objprof

@fredemmott
Copy link
Contributor

@KendallHopkins what tools were you thinking of, and what would be involved in releasing them?

@fredemmott
Copy link
Contributor

fb T58748336

@andrewjtimmons
Copy link
Author

Good afternoon @fredemmott and @KendallHopkins. I was wondering if there is a status update for this?

@fredemmott
Copy link
Contributor

Pinged on internal task.

@fredemmott
Copy link
Contributor

For FB reference: MnemonicProfiler + Heapgraph + HeapgraphUtils should be releasable.

Current problem is what other work to drop to get those released.

@andrewjtimmons
Copy link
Author

andrewjtimmons commented Jun 17, 2020

Thank you Fred!

Do you have any estimates on when this might be ready? We would love to have more insight into our memory usage.

@fredemmott
Copy link
Contributor

Sorry, no; there's currently no clearly lower-priority work to drop to provide time to work on this; it'll be brought up as part of our planning for the next 6 months along with the other things that we weren't able to get to this half.

@fredemmott
Copy link
Contributor

We're unlikely to be able to release these tools this year; that said, I'll dedicate a few days to investigation, and share what I can. This is more likely to be information than runnable tools.

@andrewjtimmons
Copy link
Author

Thank you Fred, we appreciate you taking the time to look at this and share some info.

If you also have pointers on this #8622, specifically what it might take to get some var names in obj prof that would go a long way. If we could run objprof when we OOM and even just get the top 5 or 10 memory consuming user defined vars logged it would be a huge help for debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants