HH Client hangs when starting with VS Code open

[xixixao]

Describe the bug
Running hh_client, while I have VS Code open, the client just hangs on CLI. VS Code shows no progress or error. The server logs this:

[2020-02-17 11:50:59.383] Server version is not set
[2020-02-17 11:50:59.383] Loading config exception: (Sys_error "/usr/local/etc/h
h.conf: No such file or directory")
[2020-02-17 11:50:59.383] Could not load config at /usr/local/etc/hh.conf
Informant using dummy - resigning
[2020-02-17 11:50:59.427] Starting first server
[2020-02-17 11:50:59.428] About to spawn typechecker daemon. Logs will go to /private/tmp/hh_server/zSUserszSsrbzSWorkzSHackzSmalzShack.log

[2020-02-17 11:50:59.448] Just started typechecker server with pid: 22125.
[2020-02-17 11:51:00.449] Handling client connection failed. Ignoring connection attempt.
[2020-02-17 11:51:01.451] Handling client connection failed. Ignoring connection attempt.
[2020-02-17 11:51:02.452] Handling client connection failed. Ignoring connection attempt.
[2020-02-17 11:51:03.458] Handling client connection failed. Ignoring connection attempt.
[2020-02-17 11:51:04.462] Handling client connection failed. Ignoring connection attempt.

Desktop (please complete the following information):

• OS: macOS 10.14.6
• HHVM Version:
  HipHop VM 4.41.0 (rel)
  Compiler: 1579633072_N
  Repo schema: da39a3ee5e6b4b0d3255bfef95601890afd80709
  hackc-9f137a4f9a1667da175a5adbf87a9cd131135446-4.41.0

Additional Context

Deamon logs this:

[2020-02-17 11:50:59.601] [master] Server version is not set
[2020-02-17 11:50:59.601] [master] Loading config exception: (Sys_error "/usr/local/etc/hh.conf: No such file or directory")
[2020-02-17 11:50:59.601] [master] Could not load config at /usr/local/etc/hh.conf
[2020-02-17 11:50:59.602] [master] Version: hackc-9f137a4f9a1667da175a5adbf87a9cd131135446-4.41.0
[2020-02-17 11:50:59.602] [master] Hostname: michal.local
[2020-02-17 11:50:59.609] [master] Using dfind
[2020-02-17 11:50:59.613] [master] Initializing Server (This might take some time)
[2020-02-17 11:50:59.613] [master] Init id: 2CkhpmP2uZ
[2020-02-17 11:50:59.613] [master] Initing with approach: Local_config_saved_state_disabled
[2020-02-17 11:50:59.614] [master] indexing
[2020-02-17 11:50:59.614] [master] indexing: 0.000054
[2020-02-17 11:50:59.614] [master] parsing
[2020-02-17 11:51:02.028] [master] Heap size: 7515776
[2020-02-17 11:51:02.028] [master] Parsing: 2.413786
[2020-02-17 11:51:02.028] [master] Updating file dependencies...
[2020-02-17 11:51:02.035] [master] Updated file dependencies: 0.007677
[2020-02-17 11:51:02.036] [master] resolving symbol references
[2020-02-17 11:51:02.068] [master] Heap size: 8630144
[2020-02-17 11:51:02.068] [master] Naming: 0.032866
[2020-02-17 11:51:02.071] [master] Unable to fetch sqlite symbol index: Saved states are not supported in this build.
[2020-02-17 11:51:02.071] [master] Generating [/var/folders/3g/579r5v3129d2qvf097q07gpc0000gn/T/symbolindex592f19.db] from repository [/path-to-repo]
[2020-02-17 11:51:02.075] [master] Scanned repository folder [/path-to-repo] in  [0.0 secs]
[2020-02-17 11:51:02.076] [master] Scanned HHI folder [/private/tmp/hh_server/hhi_2bac346e] in  [0.0 secs]
[2020-02-17 11:51:02.676] [master] Parsed 1148 files in  [0.6 secs]
[2020-02-17 11:51:02.706] [master] Wrote 6418 symbols to sqlite in  [0.0 secs]
[2020-02-17 11:51:02.707] [master] Initialized symbol index sqlite: [/var/folders/3g/579r5v3129d2qvf097q07gpc0000gn/T/symbolindex592f19.db]
[2020-02-17 11:51:02.708] [master] Search provider set to [Sqlite] based on configuration value [SqliteIndex]
[2020-02-17 11:51:02.708] [master] Updated search index for symbols in 1148 files:: 0.000054
[2020-02-17 11:51:02.708] [master] Done updating search index
[2020-02-17 11:51:02.708] [master] Dependency table load factor: 0 / 131072 (0.00)
[2020-02-17 11:51:02.708] [master] Hashtable load factor: 13816 / 262144 (0.05) with 13816 nonempty slots
[2020-02-17 11:51:02.708] [master] Waiting for daemon(s) to be ready...
[2020-02-17 11:51:02.708] [master] Server is partially ready
[2020-02-17 11:51:02.708] [master] Took 3.095324 seconds.
******************************************
[2020-02-17 11:51:02.811] [master] Check kind: Full_check
[2020-02-17 11:51:02.811] [master] Processing changes to 0 files
[2020-02-17 11:51:02.811] [master] Processing deferred type decl for 0 files
[2020-02-17 11:51:02.811] [master] Processing deferred typechecking for 1148 files
[2020-02-17 11:51:02.811] [master] Begin Parsing 0 files
[2020-02-17 11:51:02.811] [master] Parsing 0 files: 0.000155
[2020-02-17 11:51:02.811] [master] Heap size: 8630144
[2020-02-17 11:51:02.811] [master] Begin Updating deps
[2020-02-17 11:51:02.811] [master] Updating deps: 0.000066
[2020-02-17 11:51:02.811] [master] Begin Naming
[2020-02-17 11:51:02.812] [master] Naming: 0.000062
[2020-02-17 11:51:02.812] [master] Begin Type declaration (phase 1) for 0 files
[2020-02-17 11:51:02.812] [master] (Recomputing type declarations in changed files and determining immediate typechecking fanout)
[2020-02-17 11:51:02.813] [master] Finished recomputing type declarations:
[2020-02-17 11:51:02.813] [master]   changed: 0
[2020-02-17 11:51:02.813] [master]   to_redecl: 0
[2020-02-17 11:51:02.813] [master]   to_recheck: 0
[2020-02-17 11:51:02.813] [master] Type declaration (phase 1) for 0 files: 0.001910
[2020-02-17 11:51:02.813] [master] Heap size: 8630144
[2020-02-17 11:51:02.814] [master] Begin Type declaration (phase 2) for 0 files
[2020-02-17 11:51:02.814] [master] (Recomputing type declarations for descendants of changed classes and determining full typechecking fanout)
[2020-02-17 11:51:02.814] [master] Invalidating (but not recomputing) declarations in 0 files
[2020-02-17 11:51:02.815] [master] Finished recomputing type declarations:
[2020-02-17 11:51:02.815] [master]   changed: 0
[2020-02-17 11:51:02.815] [master]   to_redecl: 0
[2020-02-17 11:51:02.815] [master]   to_recheck: 0
[2020-02-17 11:51:02.815] [master] Type declaration (phase 2) for 0 files: 0.001622
[2020-02-17 11:51:02.815] [master] Heap size: 8630144
[2020-02-17 11:51:02.815] [master] Begin evaluating prechecked changes
[2020-02-17 11:51:02.815] [master] Evaluating prechecked changes: 0.000052
[2020-02-17 11:51:02.815] [master] Calculated whether should do remote type checking (false): 0.000044
[2020-02-17 11:51:02.815] [master] Begin Typechecking 1148 files
[2020-02-17 11:51:02.815] [master] Type checking service will process files in parallel
[2020-02-17 11:51:06.883] [master] Typechecked 1148 files: 4.067841
[2020-02-17 11:51:06.885] [master] Heap size: 13207360
[2020-02-17 11:51:06.885] [master] Total: 4.071752

[2020-02-17 11:51:06.885] [master] Dependency table load factor: 28093 / 131072 (0.21)
[2020-02-17 11:51:06.885] [master] Hashtable load factor: 29513 / 262144 (0.11) with 29513 nonempty slots
[2020-02-17 11:51:06.885] [master] Heap size: 13207360
[2020-02-17 11:51:06.885] [master] Server is READY
[2020-02-17 11:51:06.885] [master] Took 7.272135 seconds to initialize.
[2020-02-17 11:51:06.885] [master] Recheck id: uvCWbKk59q
[2020-02-17 11:51:06.885] [master] Finished recheck_loop; no diag subscriptions

[xixixao]

So the larger issue is:

On my fairly trivial toy project, the hack server crashes when I rebase far enough. VS Code shows no indication, hack typechecking and jump to definition just stops working. I then need to do the following:

1. Quit VS Code
2. hh_client stop on CLI
3. hh_client
4. Start VS Code

That's the only reliable way I found to recover.

To add more color: The server just crashed on me 3 times in the last 30 minutes. I'm rebasing between 10 commits (using Git). I have about 10 files, plus HSL in vendor (I think about <1500 files total).