Add named exports #1024
Merged
Add named exports #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you try the following:
It fails because your changes are applied on top of an old commit. |
Would love to do this:
```javascript
import { Map, Record } from 'immutable';
```
but at the moment, that's not spec compliant, since immutable only exports a default object.
Thoughts? Pardon if this has been discussed before and I just missed it. Thanks!
bspaulding
force-pushed
the
named-exports
branch
from
e7d33dc
to
166b2f9
Compare
|
Ah, duh. :) Updated. |
|
Looks good to me. @lacker please verify and |
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would love to do this:
but at the moment, that's not spec compliant, since immutable only exports a default object.
Thoughts? Pardon if this has been discussed before and I just missed it. Thanks!
Originally opened as #991, which got closed without discussion. Tests should be passing now.
I've checked in the rebuilt
distchanges, as the contributing guide says to do, but this is creating a merge conflict. Please advise if I should revert.