Updated Record to return itself on no-op set call
#795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,6 +78,12 @@ export class Record extends KeyedCollection { | |||
| if (!this.has(k)) { | |||
| throw new Error('Cannot set unknown key "' + k + '" on ' + recordName(this)); | |||
| } | |||
| if (this._map && !this._map.has(k)) { | |||
There was a problem hiding this comment.
should this be !this._map || !this._map.has(k) to also include the case where there is no map yet?
leebyron
added a commit
that referenced
this pull request
Feb 23, 2016
Updated `Record` to return itself on no-op `set` call
|
Actually this looks great. Thanks for this and also for including the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated record tests
Fixes #558 and #536