Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpe_hosts readme doesn't match behavior of cpe_hosts resource #153

Closed
discentem opened this issue Mar 19, 2018 · 1 comment
Closed

cpe_hosts readme doesn't match behavior of cpe_hosts resource #153

discentem opened this issue Mar 19, 2018 · 1 comment

Comments

@discentem
Copy link
Contributor

https://github.com/facebook/IT-CPE/tree/master/chef/cookbooks/cpe_hosts#cpe_hosts-cookbook
mentions that the resource checks for the following tags: #Start-Managed-CPE-Hosts and #End-Managed-CPE-Hosts but it appears to only be checking for entires which end with # Chef Managed.

I'm not sure which way this should go: but either the resource should be updated or the readme should.
mikedodge04 added a commit that referenced this issue Mar 21, 2018
@mikedodge04
Merge pull request #154 from chilcote/update_cpe_hosts
57c4fcf 
updating cpe_hosts. fixes #153
@discentem
Copy link
Contributor Author

Thanks @mikedodge04 and @chilcote

facebook-github-bot pushed a commit that referenced this issue Sep 25, 2020
@facebook-github-bot
Add alternate acceptable platform value for def macos? (#153)
43fccc6 
Summary:

On some versions of Chef and macOS `node['platform'] returns `macos` instead of `mac_os_x`, this PR will allow either to be acceptable respones for `node.macos?` to return true.

Pull Request resolved: facebook/chef-cookbooks#153

Reviewed By: rb2k

Differential Revision: D23932287

Pulled By: davide125

fbshipit-source-id: 3de3c67caa7228eda54fe1377df32606a2a2a373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@discentem