Skip to content

Commit

Permalink
Revert "fix(jest-runner): handle test failures with circular objects (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
SimenB committed Mar 8, 2021
1 parent ab014c1 commit e876ae0
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.md
Expand Up @@ -50,7 +50,6 @@
- `[jest-reporter]` Handle empty files when reporting code coverage with V8 ([#10819](https://github.com/facebook/jest/pull/10819))
- `[jest-resolve]` Replace read-pkg-up with escalade package ([#10781](https://github.com/facebook/jest/pull/10781))
- `[jest-resolve]` Disable `jest-pnp-resolver` for Yarn 2 ([#10847](https://github.com/facebook/jest/pull/10847))
- `[jest-runner]` Handle test failures with circular objects ([#10981](https://github.com/facebook/jest/pull/10981))
- `[jest-runtime]` [**BREAKING**] Do not inject `global` variable into module wrapper ([#10644](https://github.com/facebook/jest/pull/10644))
- `[jest-runtime]` [**BREAKING**] remove long-deprecated `jest.addMatchers`, `jest.resetModuleRegistry`, and `jest.runTimersToTime` ([#9853](https://github.com/facebook/jest/pull/9853))
- `[jest-runtime]` Fix stack overflow and promise deadlock when importing mutual dependant ES module ([#10892](https://github.com/facebook/jest/pull/10892))
Expand Down
2 changes: 1 addition & 1 deletion e2e/__tests__/circularInequality.test.ts
Expand Up @@ -26,7 +26,7 @@ afterEach(() => {
cleanup(tempDir);
});

test('handles circular inequality properly', async () => {
test.skip('handles circular inequality properly', async () => {
const testFileContent = `
it('test', () => {
const foo = {};
Expand Down
7 changes: 1 addition & 6 deletions packages/jest-runner/src/index.ts
Expand Up @@ -166,12 +166,7 @@ export default class TestRunner {

const worker = new Worker(TEST_WORKER_PATH, {
exposedMethods: ['worker'],
forkOptions: {
// use advanced serialization in order to transfer objects with circular references
// @ts-expect-error: option does not exist on the node 10 types
serialization: 'advanced',
stdio: 'pipe',
},
forkOptions: {stdio: 'pipe'},
maxRetries: 3,
numWorkers: this._globalConfig.maxWorkers,
setupArgs: [
Expand Down

0 comments on commit e876ae0

Please sign in to comment.