Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong error codes #19

Closed
kl3ryk opened this issue May 15, 2014 · 1 comment · Fixed by #21
Closed

Wrong error codes #19

kl3ryk opened this issue May 15, 2014 · 1 comment · Fixed by #21

Comments

@kl3ryk
Copy link
Contributor

kl3ryk commented May 15, 2014

After send pull request here - #18

Travis said that pull request is ready to merge.

This is not true because here: https://travis-ci.org/facebook/jest/jobs/25233025 (build: https://travis-ci.org/facebook/jest/builds/25233024) you can see that one of test has failed (under my windows enviroment all test has passed), and the exit code is 0.
sophiebits added a commit to sophiebits/jest that referenced this issue May 15, 2014
@sophiebits
Exit with status 1 for failures
58dbc0d 
Fixes jestjs#19.
@sophiebits sophiebits mentioned this issue May 15, 2014
Merged
jeffmo pushed a commit that referenced this issue May 15, 2014
Merge pull request #21 from spicyj/gh-19
de878f2 
Exit with status 1 for failures
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exit with status 1 for failures sophiebits/jest
1 participant
@kl3ryk