Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test watcher interruption properly. #2385

Closed
cpojer opened this issue Dec 20, 2016 · 4 comments · Fixed by #2491
Closed

Fix test watcher interruption properly. #2385

cpojer opened this issue Dec 20, 2016 · 4 comments · Fixed by #2491
Labels
🐛 Bug

Comments

@cpojer
Copy link
Member

cpojer commented Dec 20, 2016

62f5621
@cpojer cpojer mentioned this issue Dec 20, 2016
Merged
@rogeliog rogeliog mentioned this issue Jan 2, 2017
Merged
@cpojer
Copy link
Member Author

cpojer commented Jan 7, 2017

Should be fixed in #2362 by using a new instance of the TestWatcher.

@cpojer cpojer closed this as completed Jan 7, 2017
@rogeliog
Copy link
Contributor

rogeliog commented Jan 7, 2017

@cpojer Wouldn't #2491 still happen after #2362?

@cpojer
Copy link
Member Author

cpojer commented Jan 8, 2017

Does it still repro for you? I think it should be fixed (see the comment in watch.js).

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐛 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unhandled promise rejection in worker when parent has exited rogeliog/jest
3 participants
@cpojer @rogeliog @thymikee