Use ES module exports #4454
Merged
Use ES module exports #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4454 +/- ##
==========================================
+ Coverage 56.74% 56.86% +0.11%
==========================================
Files 189 186 -3
Lines 6485 6294 -191
Branches 3 3
==========================================
- Hits 3680 3579 -101
+ Misses 2804 2714 -90
Partials 1 1
Continue to review full report at Codecov.
|
|
Woah, nice work @SimenB. Thank you for your continued efforts to modernize the codebase. |
tabrindle
pushed a commit
to tabrindle/jest
that referenced
this pull request
Oct 2, 2017
* Use ESM exports in jest-config * Use ESM exports in eslint-plugin-jest * Use ESM exports in jest-changed-files * Use ESM exports in jest-circus * Use ESM exports in jest-diff * Use ESM exports in jest-editor-support * Use ESM exports in jest-haste-map * Use ESM exports in jest-jasmine2 * Use ESM exports in jest-message-util * Use ESM exports in jest-regex-util * Use ESM exports in jest-repl * Use ESM exports in jest-resolve * Use ESM exports in jest-runner * Use ESM exports in jest-runtime * Use ESM exports in jest-snapshot * Use ESM exports in jest-test-typescript-parser * Use ESM exports in jest-util * Use ESM exports in jest-validate * Fix flow errors * Activate eslint plugin to enforce correct ESM usage * Use ESM exports in jest-cli
tabrindle
pushed a commit
to tabrindle/jest
that referenced
this pull request
Oct 11, 2017
* Use ESM exports in jest-config * Use ESM exports in eslint-plugin-jest * Use ESM exports in jest-changed-files * Use ESM exports in jest-circus * Use ESM exports in jest-diff * Use ESM exports in jest-editor-support * Use ESM exports in jest-haste-map * Use ESM exports in jest-jasmine2 * Use ESM exports in jest-message-util * Use ESM exports in jest-regex-util * Use ESM exports in jest-repl * Use ESM exports in jest-resolve * Use ESM exports in jest-runner * Use ESM exports in jest-runtime * Use ESM exports in jest-snapshot * Use ESM exports in jest-test-typescript-parser * Use ESM exports in jest-util * Use ESM exports in jest-validate * Fix flow errors * Activate eslint plugin to enforce correct ESM usage * Use ESM exports in jest-cli
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This converts most of the commonjs usage into ESM exports.
I took care to not change to
default exportfor entrypoints, meaning that those importing individual modules can still userequirewithout issue.Might consider adding
no-commonjslint rule (https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-commonjs.md), but there are still lots of places we have to use CJS?Test plan
./jest