Flatten temporary data structures in jest-diff #4469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve in small ways now and mainly reduce complexity of code diff in future pull request.
For
Diff
replace{diff: string, isDifferent: boolean}
withstring | null
In
formatChunks
andformatHunks
return if no differences before initializing variablesIn
formatChunks
replacemap
withreduce
to eliminate some string concatenation and mainly be able in the future to display differences within adjacent pairs of removed and added chunksTest plan
Existing tests verify no change to behavior of package.