Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executing globalConfig only when there are tests available to be exec… #5323

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

anilreddykatta
Copy link
Contributor

…uted

Summary
Currently, we execute globalConfig module even when there are no tests available for execution. Fixes #5315

Test plan
Currently, we should not see "determining test suites to run" when there are no available tests.

@codecov-io
Copy link

Codecov Report

Merging #5323 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5323   +/-   ##
=======================================
  Coverage   61.25%   61.25%           
=======================================
  Files         205      205           
  Lines        6896     6896           
  Branches        3        4    +1     
=======================================
  Hits         4224     4224           
  Misses       2671     2671           
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-cli/src/run_jest.js 52.54% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd848f3...142988b. Read the comment docs.

@cpojer cpojer merged commit 7743c09 into jestjs:master Jan 15, 2018
@anilreddykatta anilreddykatta deleted the issues/jest-5315 branch January 15, 2018 20:35
@cpojer
Copy link
Member

cpojer commented Jan 15, 2018

Thanks! Could you make a second PR with an update to the changelog as well as an integration test? You could make it so that the globalSetup would call "console.log" and it would be displayed when doing "jest" but not when doing "jest thistestdoesnotexist"?

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't run globalSetup if no test suites need to be run
4 participants