Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace preset-es2015 with preset-env #5346

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Conversation

nicholaslee119
Copy link
Contributor

@nicholaslee119 nicholaslee119 commented Jan 18, 2018

preset-es2015 was already deprecated and should be replaced by preset-env
you will see this info when installing preset-es2015

We're super 馃樃 excited that you're trying to use ES2015 syntax, but instead of making more yearly presets 馃槶 , Babel now has a ?better preset that we recommend you use instead: npm install babel-preset-env --save-dev. preset-env without options will compile ES2015+ down to ES5 just like using all the presets together and thus is more future proof. It also allows you to target specific browsers so that Babel can do less work and you can ship native ES2015+ to user 馃槑 ! We are also in the process of releasing v7, so please give http://babeljs.io/blog/2017/09/12/planning-for-7.0 a read and help test it out in beta! Thanks so much for using Babel 馃檹, please give us a follow on Twitter @babeljs for news on Babel, join slack.babeljs.io for discussion/development and help support the project at opencollective.com/babel

Summary

Test plan

preset-es2015 was already deprecated and should be replaced by preset-env
you will see this info when installing preset-es2015
```
We're super 馃樃 excited that you're trying to use ES2015 syntax, but instead of making more yearly presets 馃槶 , Babel now has a ?better preset that we recommend you use instead: npm install babel-preset-env --save-dev. preset-env without options will compile ES2015+ down to ES5 just like using all the presets together and thus is more future proof. It also allows you to target specific browsers so that Babel can do less work and you can ship native ES2015+ to user 馃槑 ! We are also in the process of releasing v7, so please give http://babeljs.io/blog/2017/09/12/planning-for-7.0 a read and help test it out in beta! Thanks so much for using Babel 馃檹, please give us a follow on Twitter @babeljs for news on Babel, join slack.babeljs.io for discussion/development and help support the project at opencollective.com/babel
```
@codecov-io
Copy link

Codecov Report

Merging #5346 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5346   +/-   ##
=======================================
  Coverage   61.32%   61.32%           
=======================================
  Files         205      205           
  Lines        6909     6909           
  Branches        3        4    +1     
=======================================
  Hits         4237     4237           
  Misses       2671     2671           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f040725...e1f3cff. Read the comment docs.

@SimenB SimenB merged commit e8eb1d1 into jestjs:master Jan 19, 2018
@SimenB
Copy link
Member

SimenB commented Jan 19, 2018

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants