Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Webstie images #5349

Merged
merged 4 commits into from
Jan 19, 2018
Merged

Optimize Webstie images #5349

merged 4 commits into from
Jan 19, 2018

Conversation

genintho
Copy link
Contributor

This PR simply run the images used on the documentation site through https://imageoptim.com/ with the default settings to apply losseless optimization

I confirmed that everything looked good by running yarn start inside the website directory and poking around the site.

Some stats
screen shot 2018-01-18 at 23 51 43
screen shot 2018-01-18 at 23 56 48
screen shot 2018-01-19 at 00 07 32

@codecov-io
Copy link

Codecov Report

Merging #5349 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5349     +/-   ##
=========================================
- Coverage   61.32%   61.22%   -0.1%     
=========================================
  Files         205      205             
  Lines        6909     6894     -15     
  Branches        4        3      -1     
=========================================
- Hits         4237     4221     -16     
- Misses       2671     2672      +1     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-editor-support/src/Process.js 14.28% <0%> (-45.72%) ⬇️
packages/jest-util/src/index.js 89.47% <0%> (-10.53%) ⬇️
packages/jest-editor-support/src/Runner.js 63.15% <0%> (-4.8%) ⬇️
packages/jest-runner/src/index.js 37.77% <0%> (-1.36%) ⬇️
packages/jest-cli/src/test_scheduler.js 25.54% <0%> (-1.27%) ⬇️
packages/jest-runtime/src/index.js 73.62% <0%> (-0.37%) ⬇️
packages/jest-cli/src/watch.js 70.06% <0%> (-0.19%) ⬇️
.../src/get_no_test_found_related_to_changed_files.js 0% <0%> (ø) ⬆️
packages/jest-config/src/normalize.js 93.1% <0%> (ø) ⬆️
packages/jest-cli/src/reporters/notify_reporter.js 8.69% <0%> (ø) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8eb1d1...29342c8. Read the comment docs.

@cpojer cpojer merged commit fbcbf21 into jestjs:master Jan 19, 2018
@cpojer
Copy link
Member

cpojer commented Jan 19, 2018

Awesome! Thanks for making the Jest website faster.

@genintho genintho deleted the optimize-image branch June 2, 2018 03:43
thymikee pushed a commit that referenced this pull request Aug 8, 2018
This PR optimize the site images, using lossy algorithm. I did one of these in the past (#5349).


You might want to consider using the tool (https://www.shrink.sh) I used to generate this PR. Disclaimer, I am the author, and I wrote it exactly to solve this problem: it is too easy to forget the optimize images. The tool is triggered when new images are pushed on the master branch of a repo. Rebasing my fork with upstream triggered it.


Below is the PR description generated by the tool.

----

# 🤖 Reduce image sizes by 49%!



### Optimized Images
#| 📁  File     | Original Size | New Size      | Savings
-|--------------|---------------|---------------|--------------
✅ | 16-snapshots.png | 150.10 KiB | 142.55 KiB | -5%
✅ | interactiveSnapshot.png | 128.66 KiB | 109.02 KiB | -15%
✅ | interactiveSnapshotUpdate.gif | 805.99 KiB | 511.21 KiB | -36%
✅ | interactiveSnapshotDone.png | 33.09 KiB | 28.03 KiB | -15%
✅ | airbnb.png | 51.70 KiB | 31.84 KiB | -38%
✅ | default-demo.gif | 7.25 MiB | 3.82 MiB | -47%
✅ | describe-demo.gif | 5.26 MiB | 2.48 MiB | -52%
✅ | tagged-template-literal.gif | 4.12 MiB | 1.41 MiB | -65%
✅ | test-demo.gif | 4.52 MiB | 2.23 MiB | -50%
✅ | 23-asymmetric-matchers.png | 265.32 KiB | 148.20 KiB | -44%
✅ | 23-async-matchers.png | 179.54 KiB | 99.34 KiB | -44%
✅ | 23-hanging-after.png | 233.85 KiB | 144.74 KiB | -38%
✅ | 23-hanging-before.png | 190.30 KiB | 117.83 KiB | -38%
✅ | 23-interactive.gif | 824.47 KiB | 655.32 KiB | -20%
✅ | 23-jest-each.png | 235.91 KiB | 129.32 KiB | -45%
✅ | 23-new-matchers.png | 295.07 KiB | 167.39 KiB | -43%
✅ | 23-snapshot-matchers.png | 344.73 KiB | 246.78 KiB | -28%
✅ | 23-typeahead.gif | 308.19 KiB | 181.83 KiB | -40%
🍪|**Total**| 25.11 MiB | 12.59 MiB | -49%
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants