Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load modules from node_modules before custom paths #5403

Merged
merged 4 commits into from
Jan 27, 2018
Merged

Conversation

vlasy
Copy link
Contributor

@vlasy vlasy commented Jan 27, 2018

Summary

It resolves #5377

Test plan
I ran yarn test and it passed correctly

I signed the CLA

@codecov-io
Copy link

codecov-io commented Jan 27, 2018

Codecov Report

Merging #5403 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5403      +/-   ##
==========================================
+ Coverage   61.32%   61.35%   +0.02%     
==========================================
  Files         205      205              
  Lines        6925     6925              
  Branches        3        3              
==========================================
+ Hits         4247     4249       +2     
+ Misses       2677     2675       -2     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-resolve/src/node_modules_paths.js 100% <100%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922b037...3e28cc7. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Jan 27, 2018

@vlasy thanks! Could you update the changelog as well?

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest's require looks for modules in different order than Node.js
5 participants