Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Adding Suggested Badge (#5438) #5458

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Docs: Adding Suggested Badge (#5438) #5458

merged 1 commit into from
Feb 5, 2018

Conversation

aleen42
Copy link
Contributor

@aleen42 aleen42 commented Feb 5, 2018

Adding Suggested Badge discussed in #5438

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

SimenB
SimenB reviewed Feb 5, 2018
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

README.md Outdated
@@ -188,10 +188,11 @@ Learn more about using
## Badge

Show the world you're using _Jest_ →
[![tested with jest](https://img.shields.io/badge/tested_with-jest-99424f.svg)](https://github.com/facebook/jest)
[![tested with jest](https://img.shields.io/badge/tested_with-jest-99424f.svg)](https://github.com/facebook/jest) [![jest](https://cdn.rawgit.com/aleen42/badges/master/src/jest_2.svg)](https://github.com/facebook/jest)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the file be hosted on the jest website?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB Sure, where is the repository of the jset website?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the website folder in this repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be specific: https://github.com/facebook/jest/tree/master/website/static/img

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I will change this PR later.

@codecov-io
Copy link

codecov-io commented Feb 5, 2018 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@ae3d55e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5458   +/-   ##
=========================================
  Coverage          ?   62.19%           
=========================================
  Files             ?      205           
  Lines             ?     6930           
  Branches          ?        4           
=========================================
  Hits              ?     4310           
  Misses            ?     2619           
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae3d55e...c87067c. Read the comment docs.

SimenB
SimenB reviewed Feb 5, 2018
View reviewed changes
README.md Outdated
@@ -188,10 +188,11 @@ Learn more about using
## Badge

Show the world you're using _Jest_ →
[![tested with jest](https://img.shields.io/badge/tested_with-jest-99424f.svg)](https://github.com/facebook/jest)
[![tested with jest](https://img.shields.io/badge/tested_with-jest-99424f.svg)](https://github.com/facebook/jest) [![jest](https://rawgit.com/facebook/jest/master/website/static/img/jest-badge.svg)](https://github.com/facebook/jest)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once deployed, it will be available at https://facebook.github.io/jest/img/female-technologist/jest-badge.svg, which would be better than rawgit, I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps facebook.github.io maybe better, as I found rawgit.com has already been banned from accessing in CN.

@cpojer cpojer merged commit bda02e6 into jestjs:master Feb 5, 2018
@renovate renovate bot mentioned this pull request Feb 14, 2018
Open
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpojer cpojer cpojer left review comments

@SimenB SimenB SimenB left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aleen42 @facebook-github-bot @codecov-io @cpojer @SimenB