Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-cli): use correct filename to override config #10337

Merged
merged 3 commits into from Jul 31, 2020

Conversation

@sibiraj-s
Copy link
Contributor

sibiraj-s commented Jul 30, 2020

Summary

Init with existing config should override the config with correct filename.

Test plan

Bug
Screenshot 2020-07-30 at 8 09 41 PM

When overriding jest config it creates a file only with extension.

Fix

Screenshot 2020-07-30 at 8 11 35 PM

@sibiraj-s sibiraj-s changed the title fix(init): use correct filename to override config fix(jest-cli): use correct filename to override config Jul 30, 2020
@SimenB
SimenB approved these changes Jul 31, 2020
Copy link
Collaborator

SimenB left a comment

thanks!

@SimenB SimenB merged commit 0708daf into facebook:master Jul 31, 2020
16 checks passed
16 checks passed
cleanup-runs
Details
Running TypeScript compiler & ESLint
Details
Node v10.x on ubuntu-latest
Details
Node v10.x on macOS-latest
Details
Node v10.x on windows-latest
Details
Node v12.x on ubuntu-latest
Details
Node v12.x on macOS-latest
Details
Node v12.x on windows-latest
Details
Node v13.x on ubuntu-latest
Details
Node v13.x on macOS-latest
Details
Node v13.x on windows-latest
Details
Node v14.x on ubuntu-latest
Details
Node v14.x on macOS-latest
Details
Node v14.x on windows-latest
Details
Facebook CLA Check Contributor License Agreement is valid!
Details
facebook.jest #20200730.25 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.