Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require.main is undefined on using jest.resetModules #10626

Merged
merged 7 commits into from
Oct 13, 2020

Conversation

flozender
Copy link
Contributor

Summary

Closes #10625.

require.main is undefined on using the --resetModules flag. This PR aims to resolve this issue.

Test plan

E2E tests added

@flozender flozender marked this pull request as draft October 12, 2020 19:17
@flozender flozender marked this pull request as ready for review October 12, 2020 19:36
@flozender flozender marked this pull request as draft October 12, 2020 21:35
@flozender flozender marked this pull request as ready for review October 13, 2020 09:04
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
@SimenB SimenB merged commit 3641e3c into jestjs:master Oct 13, 2020
@jsg2021
Copy link

jsg2021 commented Oct 13, 2020

Looking forward to this getting released :)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require.main is undefined ...when resetModules=true? (maybe)
4 participants